Re: [PATCH 1/6] dt-bindings: media: qcom,sm8650-camss: Add test pattern generators

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: media: qcom,sm8650-camss: missing minItems on reg and clocks
--

commit e38622494d300e76674ad2714e0222a5d2a3e220
Author: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>

dt-bindings: media: qcom,sm8650-camss: Add test pattern generators

This commit adds the three test pattern generator (TPG) register spaces and
the non-real time CAMNOC AXI clock to the Qualcomm SM8650 CAMSS device tree
binding schema.

> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8650-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sm8650-camss.yaml
> index 9c8de722601ec..50ae30cdcb82a 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sm8650-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sm8650-camss.yaml
> @@ -17,7 +17,7 @@ properties:
>      const: qcom,sm8650-camss
>  
>    reg:
> -    maxItems: 17
> +    maxItems: 20
>  
>    reg-names:
>      items:
> @@ -38,9 +38,12 @@ properties:
>        - const: vfe2
>        - const: vfe_lite0
>        - const: vfe_lite1
> +      - const: tpg0
> +      - const: tpg1
> +      - const: tpg2
>  
>    clocks:
> -    maxItems: 33
> +    maxItems: 34
>  
>    clock-names:
>      items:
> @@ -77,6 +80,7 @@ properties:
>        - const: vfe_lite_ahb
>        - const: vfe_lite_cphy_rx
>        - const: vfe_lite_csid
> +      - const: camnoc_nrt_axi

[Severity: Medium]
Should reg and reg-names specify minItems: 17, and should clocks and
clock-names specify minItems: 33 in
Documentation/devicetree/bindings/media/qcom,sm8650-camss.yaml?

In dtschema, increasing maxItems on reg from 17 to 20 and on clocks from
33 to 34 (while appending tpg0, tpg1, tpg2 to reg-names and camnoc_nrt_axi
to clock-names) without specifying minItems implicitly sets minItems equal
to maxItems. This makes the newly added TPG register blocks and clock
mandatory rather than optional.

Existing qcom,sm8650-camss device tree nodes such as in
arch/arm64/boot/dts/qcom/sm8650.dtsi (introduced in commit e8560ac937d92e)
provide 17 reg/reg-names entries and 33 clocks/clock-names entries prior to
the DTS update in this series, or when the binding and driver changes merge
through the media tree independently of the Qualcomm SoC DTS tree. In
addition, commit c865d36a9474 ("media: qcom: camss: Skip TPG if its
registers are not described") in this series explicitly keeps TPG optional
in camss_probe() for backward compatibility with older device trees.

Without minItems: 17 on reg and reg-names and minItems: 33 on clocks and
clock-names, does dtbs_check fail validation on existing qcom,sm8650-camss
device trees that omit the TPG entries?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261031112203.545319-1-vladimir.zapolskiy@linaro.org?part=1