Re: [PATCH 1/3] dt-bindings: mfd: nxp,bbnsm: Add NVMEM for GP registers

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: mfd: nxp,bbnsm: additionalProperties: false breaks nvmem schema
--

commit 9d4b26f677f71a4d6410c83a13726309dd8d81b5
Author: Stefan Wahren <wahrenst@gmx.net>

dt-bindings: mfd: nxp,bbnsm: Add NVMEM for GP registers

This commit documents the device tree bindings for the optional
Battery-Backed Non-Secure Module general purpose registers available on
i.MX9 SoCs.

> diff --git a/Documentation/devicetree/bindings/mfd/nxp,bbnsm.yaml b/Documentation/devicetree/bindings/mfd/nxp,bbnsm.yaml
> index b1ade64a15541..4c4b7c3fff2a2 100644
> --- a/Documentation/devicetree/bindings/mfd/nxp,bbnsm.yaml
> +++ b/Documentation/devicetree/bindings/mfd/nxp,bbnsm.yaml
> @@ -31,6 +31,20 @@ properties:
>    reg:
>      maxItems: 1
>  
> +  nvmem:
> +    type: object
> +    $ref: /schemas/nvmem/nvmem.yaml#
> +
> +    properties:
> +      compatible:
> +        enum:
> +          - nxp,imx93-bbnsm-nvmem
> +
> +    required:
> +      - compatible
> +
> +    additionalProperties: false
> +
>    rtc:
>      type: object
>      $ref: /schemas/rtc/rtc.yaml#
> @@ -88,6 +102,12 @@ examples:
>          compatible = "nxp,imx93-bbnsm", "syscon", "simple-mfd";
>          reg = <0x44440000 0x10000>;
>  
> +        nvmem {
> +            compatible = "nxp,imx93-bbnsm-nvmem";
> +            #address-cells = <1>;
> +            #size-cells = <1>;
> +        };

[Severity: Medium]
Should the nvmem subnode schema use unevaluatedProperties: false instead
of additionalProperties: false?

Because nvmem references /schemas/nvmem/nvmem.yaml# via $ref and only
defines compatible in its local properties block, additionalProperties:
false rejects all properties inherited from nvmem.yaml#.

As a result, running dt_binding_check or dtbs_check fails on
#address-cells and #size-cells in the example above, as well as on any
device tree node using standard NVMEM provider properties.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261101200140.141642-1-wahrenst@gmx.net?part=1