Re: [PATCH v3 10/12] arm64: dts: qcom: sm6350-lena: Add PM7250B thermals

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] arm64: dts: qcom: sm6350-lena: xo-thermal overwritten by chg-skin-thermal
--

commit f17bc49f693d9b82548c205964560df1771e0079
Author: erebion <erebion@erebion.eu>

arm64: dts: qcom: sm6350-lena: Add PM7250B thermals

This commit adds thermal zones for the chg-skin-thermal and conn-thermal
thermistors connected to PM7250B on Sony Xperia 10 III (pdx213).

> diff --git a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
> index 6d5aa2fce4c0f..4e9707712a651 100644
> --- a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
> +++ b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
> @@ -91,8 +91,8 @@ memory@fe901000 {
>  	};
>  
>  	thermal-zones {
> -		xo-thermal {
> -			thermal-sensors = <&pmk8350_adc_tm 0>;
> +		chg-skin-thermal {
> +			thermal-sensors = <&pm7250b_adc_tm 0>;

[Severity: Medium]
Was xo-thermal intentionally removed here?

In the preceding commits ("arm64: dts: qcom: sm6350-lena: Enable PMK8350"
and "arm64: dts: qcom: sm6350-lena: Add PMK8350 thermals"), pmk8350_adc_tm
is enabled with child node xo-therm@0:

&pmk8350_adc_tm {
	status = "okay";

	xo-therm@0 {
		reg = <0>;
		io-channels = <&pmk8350_vadc PMK8350_ADC7_AMUX_THM1_100K_PU>;
		qcom,hw-settle-time-us = <200>;
		qcom,ratiometric;
	};
};

and the xo-thermal zone referencing <&pmk8350_adc_tm 0> is added under
thermal-zones.

Here, chg-skin-thermal replaces xo-thermal in-place rather than being added
alongside it. When drivers/thermal/qcom/qcom-spmi-adc-tm5.c probes
pmk8350_adc_tm via adc_tm5_probe() -> adc_tm5_register_tzd() ->
devm_thermal_of_zone_register(), registering channel 0 fails with -ENODEV
because no thermal zone references <&pmk8350_adc_tm 0> at this commit.

It looks like a hunk-splitting error across the series, as the subsequent
commit ("arm64: dts: qcom: sm6350-lena: Add PM6150L thermals") re-adds the
deleted xo-thermal node at the end of thermal-zones. Should xo-thermal be
preserved in this commit instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261102-pdx213-upstream-3-v3-0-cdc3be96d257@erebion.eu?part=10