Re: [PATCH v5 1/3] dt-bindings: iio: add: document the MAX34417 Four-Channel High Dynamic Range Power Accumulator

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: iio: adc: adi,max34417: inconsistent indentation in DTS example
--

commit a9428a6f2a12de2abe990a839ca0d1e5820c2ceb
Author: Neil Armstrong <neil.armstrong@linaro.org>

dt-bindings: iio: add: document the MAX34417 Four-Channel High Dynamic Range Power Accumulator

This patch adds a Device Tree binding schema for the Analog Devices
MAX34417 Four-Channel High Dynamic Range Power Accumulator.

> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,max34417.yaml b/Documentation/devicetree/bindings/iio/adc/adi,max34417.yaml
> new file mode 100644
> index 0000000000000..700bc3ca7d7cf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,max34417.yaml
> @@ -0,0 +1,103 @@

[ ... ]

> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        sensor@10 {
> +              compatible = "adi,max34417";
> +              reg = <0x10>;
> +
> +              vdd-supply = <&max34417_vdd>;
> +              vio-supply = <&max34417_vio>;
> +
> +              #address-cells = <1>;
> +              #size-cells = <0>;
> +
> +              channel@0 {
> +                  reg = <0>;
> +                  label = "ch0";
> +                  shunt-resistor-micro-ohms = <5000>;
> +              };
> +
> +              channel@1 {
> +                  reg = <1>;
> +                  label = "ch1";
> +             };
> +
> +              channel@2 {
> +                  reg = <2>;
> +             };
> +        };
> +    };

[Severity: Low]
As reported by Krzysztof Kozlowski on v2 [1], the DTS example in
Documentation/devicetree/bindings/iio/adc/adi,max34417.yaml has inconsistent
indentation that fails scripts/dtc/dt-check-style --mode strict.

Inside sensor@10, the properties and child channel nodes are indented by 6
spaces relative to sensor@10 instead of 4 spaces, and the closing braces for
channel@1 and channel@2 are misaligned by one space relative to their opening
lines.

Should the example use consistent 4-space indentation throughout sensor@10 and
its child channel nodes?

[1] https://lore.kernel.org/r/20260929-heavy-intelligent-guillemot-da269b@quoll

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261102-topic-sm8x50-iio-max34417-adc-v5-0-0ffa5e5f2d5c@linaro.org?part=1