From: sashiko-bot@kernel.org
To: "Quentin Schulz" <foss+kernel@0leil.net>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: rockchip: enable OV9281 CAM0 P14 on RK3588 Jaguar
Date: Mon, 02 Nov 2026 20:41:18 +0000 [thread overview]
Message-ID: <sashiko-outbox-194142@kernel.org> (raw)
In-Reply-To: <20261102-jaguar-cam0-cam1-v1-1-c3aafcdab5dd@cherry.de>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] arm64: dts: rockchip: underscore in cam0_p14 pinctrl node name
--
commit d626daefe6323fd02925a1f931694d66c7b92c2d
Author: Quentin Schulz <quentin.schulz@cherry.de>
arm64: dts: rockchip: enable OV9281 CAM0 P14 on RK3588 Jaguar
This commit adds a device tree overlay for the P14 camera module on the
RK3588 Jaguar board, supporting an OV9281 camera sensor, an IMU, a
magnetometer, and an EEPROM.
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-jaguar-p14-ov9281.dtso b/arch/arm64/boot/dts/rockchip/rk3588-jaguar-p14-ov9281.dtso
> new file mode 100644
> index 0000000000000..155101c8497de
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-jaguar-p14-ov9281.dtso
> @@ -0,0 +1,113 @@
[ ... ]
> +&pinctrl {
> + cam0_p14 {
> + cam0_imu_int3: cam0-imu-int3 {
> + rockchip,pins = <1 RK_PC7 RK_FUNC_GPIO &pcfg_pull_none>;
> + };
[Severity: Low]
Should the cam0_p14 node under &pinctrl in
arch/arm64/boot/dts/rockchip/rk3588-jaguar-p14-ov9281.dtso be named cam0-p14
using a hyphen instead of an underscore?
Device tree coding style reserves underscores for labels and uses hyphens in
node names, and building with W=2 enables -Wnode_name_chars_strict in dtc,
which warns about the underscore in cam0_p14.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261102-jaguar-cam0-cam1-v1-0-c3aafcdab5dd@cherry.de?part=1
next prev parent reply other threads:[~2026-11-02 20:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 20:30 [PATCH 0/2] arm64: dts: rockchip: enable OV9281 CAM0 and CAM1 on RK3588 Jaguar Quentin Schulz
2026-11-02 20:30 ` [PATCH 1/2] arm64: dts: rockchip: enable OV9281 CAM0 P14 " Quentin Schulz
2026-11-02 20:41 ` sashiko-bot [this message]
2026-11-02 20:30 ` [PATCH 2/2] arm64: dts: rockchip: enable OV9281 CAM1 P15 " Quentin Schulz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-194142@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=foss+kernel@0leil.net \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox