Re: [PATCH v2 01/11] dt-bindings: gpio: vf610: fix clock requirements per SoC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: gpio: vf610: unwieldy per-compatible conditionals in schema
--

commit f45327f7512fd2e644abcea33601844cbc02415b
Author: Peng Fan <peng.fan@nxp.com>

dt-bindings: gpio: vf610: fix clock requirements per SoC

This patch updates Documentation/devicetree/bindings/gpio/gpio-vf610.yaml to
set minItems: 1 on clocks and clock-names and adds per-compatible if-then
rules under allOf requiring two clocks for fsl,imx7ulp-gpio and one clock for
fsl,imx8ulp-gpio.

> diff --git a/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml b/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml
> index a31f64b6d40b4..822fa11d18d97 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml
> +++ b/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml
> @@ -57,11 +57,13 @@ properties:
>      maxItems: 32
>  
>    clocks:
> +    minItems: 1
>      items:
>        - description: SoC GPIO clock
>        - description: SoC PORT clock
>  
>    clock-names:
> +    minItems: 1
>      items:
>        - const: gpio
>        - const: port
> @@ -116,6 +118,36 @@ allOf:
>          reg:
>            items:
>              - description: GPIO register base address
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: fsl,imx7ulp-gpio
> +    then:
> +      properties:
> +        clocks:
> +          minItems: 2
> +          maxItems: 2
> +        clock-names:
> +          minItems: 2
> +          maxItems: 2
> +      required:
> +        - clocks
> +        - clock-names
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: fsl,imx8ulp-gpio
> +    then:
> +      properties:
> +        clocks:
> +          maxItems: 1
> +        clock-names:
> +          maxItems: 1
> +      required:
> +        - clocks
> +        - clock-names

[Severity: Low]
This isn't a bug, but in Documentation/devicetree/bindings/gpio/gpio-vf610.yaml
nearly every hardware resource property now differs between the
fsl,vf610-gpio / fsl,imx7ulp-gpio dual-module PORT+GPIO controller and the
fsl,imx8ulp-gpio family (including fsl,imx93-gpio, fsl,imx94-gpio, and
fsl,imx95-gpio), which does not share a compatible fallback with
fsl,vf610-gpio.

The existing conditional in allOf already splits reg and interrupts between the
two hardware families:

  - if:
      properties:
        compatible:
          contains:
            enum:
              - fsl,vf610-gpio
              - fsl,imx7ulp-gpio
    then:
      properties:
        interrupts:
          maxItems: 1
        reg:
          items:
            - description: PORT register base address
            - description: GPIO register base address
    else:
      properties:
        interrupts:
          minItems: 2
        reg:
          items:
            - description: GPIO register base address

With clocks and clock-names also diverging across variants, would it be
cleaner to split the fsl,imx8ulp-gpio binding into a separate schema document
(or at least fold the fsl,imx8ulp-gpio clock constraints into the existing
else branch above) rather than adding more per-compatible if-then blocks to
allOf?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261103-gpio-vf610-fixes-v2-0-7c71fb36e184@nxp.com?part=1