Re: [PATCH v5 1/3] dt-bindings: usb: Add CIX Sky1 USBSSP controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: usb: cix,sky1-usbssp: invalid bus node name and property order
--

commit 26d70ffe3b921fd15f5adca3d546e808116719c0
Author: Hongliang Yang (杨宏亮) <hongliang.yang@cixtech.com>

dt-bindings: usb: Add CIX Sky1 USBSSP controller

This commit adds the Device Tree binding schema for the CIX Sky1 Cadence
USBSSP controller glue layer and updates MAINTAINERS.

> diff --git a/Documentation/devicetree/bindings/usb/cix,sky1-usbssp.yaml b/Documentation/devicetree/bindings/usb/cix,sky1-usbssp.yaml
> new file mode 100644
> index 0000000000000..c29654567e765
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/cix,sky1-usbssp.yaml
> @@ -0,0 +1,152 @@
[ ... ]
> +properties:
> +  compatible:
> +    const: cix,sky1-usbssp
> +
> +  reg:
> +    items:
> +      - description: AXI bus attribute configuration registers
> +      - description: Controller status registers
> +
> +  reg-names:
> +    items:
> +      - const: axi
> +      - const: status
[ ... ]
> +  cix,usb-syscon:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description:
> +      Phandle to the Sky1 S5 system controller used to program USB mode
> +      strap controls.
> +
> +  "#address-cells":
> +    const: 2
> +
> +  "#size-cells":
> +    const: 2
> +
> +  ranges: true
> +
> +patternProperties:
> +  "^usb@[0-9a-f]+$":
> +    $ref: cdns,usb3.yaml#
> +
> +required:
> +  - compatible
> +  - reg
> +  - reg-names
> +  - clocks
> +  - clock-names
> +  - resets
> +  - reset-names
> +  - cix,usb-syscon
> +  - "#address-cells"
> +  - "#size-cells"
> +  - ranges
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/cix,sky1.h>
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    #include <dt-bindings/reset/cix,sky1-s5-system-control.h>
> +
> +    soc {
> +        #address-cells = <2>;
> +        #size-cells = <2>;
> +
> +        usb-rcsu@91c0300 {
> +            compatible = "simple-bus";
> +            #address-cells = <2>;
> +            #size-cells = <2>;
> +            ranges = <0x00 0x00000000 0x00 0x091c0300 0x00 0x150>,
> +                     <0x00 0x091d0000 0x00 0x091d0000 0x00 0x20000>;

[Severity: Low]
Does this pass make dt_binding_check and scripts/dtc/dt-check-style
--mode=strict?

In the example, usb-rcsu@91c0300 has compatible = "simple-bus", which
requires a node name matching ^(bus|soc|axi|ahb|apb|isa|pci-ep-bus)(@[0-9a-f]+)?$
under schemas/simple-bus.yaml (such as bus@91c0300).

Also, in usb-rcsu@91c0300, ranges is placed after #address-cells and
#size-cells, which triggers a property-order warning from
scripts/dtc/dt-check-style --mode=strict since ranges should precede
standard properties per Documentation/devicetree/bindings/dts-coding-style.rst.

Similarly, in the top-level properties and required lists of
Documentation/devicetree/bindings/usb/cix,sky1-usbssp.yaml, should ranges
be placed right after reg-names rather than after cix,usb-syscon,
#address-cells, and #size-cells per
Documentation/devicetree/bindings/writing-schema.rst?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261103074929.1971195-1-hongliang.yang@cixtech.com?part=1