Re: [PATCH v6 04/12] media: iris: Add non-pixel and pixel context bank devices

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] media: iris: leaked IOVA reservation in iris_probe() on cb_dev init error
--

commit 67ee85a9fa8ce0ee52eff0dcecaffb30a10495d5
Author: Vikash Garodia <vikash.garodia@oss.qualcomm.com>

media: iris: Add non-pixel and pixel context bank devices

This commit adds helper functions to create and clean up separate non-pixel
and pixel context bank platform devices from device tree subnodes during
iris_probe() and teardown.

> diff --git a/drivers/media/platform/qcom/iris/iris_probe.c b/drivers/media/platform/qcom/iris/iris_probe.c
> index 25876957381b9..e659461716ba4 100644
> --- a/drivers/media/platform/qcom/iris/iris_probe.c
> +++ b/drivers/media/platform/qcom/iris/iris_probe.c

[ ... ]

> @@ -351,6 +413,10 @@ static int iris_probe(struct platform_device *pdev)
>  	if (ret)
>  		goto err_put_core;
>  
> +	ret = iris_init_cb_devs(core);
> +	if (ret)
> +		goto err_put_core;

[Severity: Medium]
In drivers/media/platform/qcom/iris/iris_probe.c, iris_probe() calls
iris_reserve_iova_region() right before iris_init_cb_devs(core):

	ret = iris_reserve_iova_region(dev, &core->iova_state, IRIS_NP_RESERVE_IOVA_START,
				       IRIS_NP_RESERVE_IOVA_SIZE);
	if (ret)
		goto err_put_core;

	ret = iris_init_cb_devs(core);
	if (ret)
		goto err_put_core;

	ret = v4l2_device_register(dev, &core->v4l2_dev);
	if (ret)
		goto err_unresv_iova_region;

	...

err_unresv_iova_region:
	iris_unreserve_iova_region(dev, core->iova_state);
err_put_core:
	v4l2_device_put(&core->v4l2_dev);

If iris_init_cb_devs() fails (for example, if platform_device_register_full()
returns an error in iris_create_cb_dev()), jumping to err_put_core skips
iris_unreserve_iova_region(dev, core->iova_state).

Does this leak the IOVA reservation in the parent device's IOMMU domain, and
should the error path jump to err_unresv_iova_region instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261103-vpu_iommu_iova_handling-v6-0-e4b6ad864f8f@oss.qualcomm.com?part=4