Re: [PATCH v2 1/5] dt-bindings: pinctrl: add the NXP LX2160A RCW pad mux

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: pinctrl: lx2160a: missing clk-out function for clk-out group
--

commit 099426f7b054b7c6ba8ac26438539221c6367516
Author: Vincent Jardin <vjardin@free.fr>

dt-bindings: pinctrl: add the NXP LX2160A RCW pad mux

This commit adds the Device Tree binding schema for the NXP LX2160A RCW
pad muxes, defining the valid pin groups and functions mapped to the
RCWSR12..14 registers of DCFG.

> diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,lx2160a-rcw-pinmux.yaml b/Documentation/devicetree/bindings/pinctrl/fsl,lx2160a-rcw-pinmux.yaml
> new file mode 100644
> index 0000000000000..b1ccd153a43bb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/fsl,lx2160a-rcw-pinmux.yaml
> @@ -0,0 +1,262 @@
[ ... ]
> +patternProperties:
> +  '-pins$':
> +    type: object
> +    $ref: pinmux-node.yaml#
> +    additionalProperties: false
> +
> +    properties:
> +      function:
> +        enum: [ asleep, can, evt, flexspi, flextimer, gpio, i2c, irq,
> +                reset-req, sdhc, sdhc-clk, sdhc-data, sdhc-data4, sdhc-spi,
> +                spi, uart, uart3, uart4 ]
> +
> +      groups:
> +        items:
> +          enum: [ iic1, iic2, iic3, iic4, iic5, iic6, xspi1-data74,
> +                  xspi1-data30, xspi1-base, sdhc1-base, sdhc1-dir,
> +                  sdhc2-data74, sdhc2-base, uart1-soutsin, uart1-rtscts,
> +                  uart2-soutsin, uart2-rtscts, irq11-8, irq7-4, irq3-0,
> +                  evt4-3, evt2-0, clk-out, asleep, reset-req ]

[Severity: Medium]
Should clk-out also be listed in the function enum (with a corresponding
if/then rule in allOf allowing the clk-out group)?

The other single-pad groups in RCWSR14 (asleep for ASLEEP_PMUX and
reset-req for RESET_REQ_PMUX) expose their encoding 0 primary functions
(asleep and reset-req) alongside their alternate functions.

For the clk-out group (CLK_OUT_PMUX in RCWSR14[5:3]), the schema permits
the gpio (0b001) and flextimer (0b010) functions in allOf, but omits the
primary clk-out (0b000) function, which prevents a board from selecting or
restoring the CLK_OUT function via pinctrl states without failing schema
validation.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261103-for-upstream-lx2160a-rcw-pinmux-v1-v2-0-3aad0860b984@free.fr?part=1