Re: [PATCH RESEND v7 1/2] dt-bindings: input: Add Qualcomm SPMI PMIC haptics

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: input: qcom,spmi-haptics example fails spmi-pmic schema check
--

commit f214feaff6e5674dfe8f6c74a27c54575bdbebcc
Author: Fenglin Wu <fenglin.wu@oss.qualcomm.com>

dt-bindings: input: Add Qualcomm SPMI PMIC haptics

This commit adds the Device Tree binding schema for the haptics module inside
Qualcomm SPMI PMICs such as PMIH0108.

> diff --git a/Documentation/devicetree/bindings/input/qcom,spmi-haptics.yaml b/Documentation/devicetree/bindings/input/qcom,spmi-haptics.yaml
> new file mode 100644
> index 0000000000000..ce2c9e893a0d7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/qcom,spmi-haptics.yaml
> @@ -0,0 +1,139 @@

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <dt-bindings/spmi/spmi.h>
> +
> +    pmic@7 {
> +        compatible = "qcom,pmih0108", "qcom,spmi-pmic";
> +        reg = <0x7 SPMI_USID>;
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        haptics@f000 {
> +            compatible = "qcom,pmih0108-haptics", "qcom,spmi-haptics";
> +            reg = <0xf000>, <0xf100>;
> +            reg-names = "cfg", "ptn";
> +            interrupts = <0x7 0xf0 0x1 IRQ_TYPE_EDGE_RISING>;
> +            interrupt-names = "fifo-empty";
> +
> +            qcom,vmax-microvolt = <1300000>;
> +            qcom,lra-period-us = <5880>;
> +        };
> +    };

[Severity: Low]
As reported by Sashiko on v6 [1], in the examples section of
Documentation/devicetree/bindings/input/qcom,spmi-haptics.yaml, the child
node haptics@f000 is placed under a parent pmic@7 node with
compatible = "qcom,pmih0108", "qcom,spmi-pmic".

When dt-validate checks this example against all schemas, pmic@7 is validated
against Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml, which lists
allowed child node patterns under patternProperties and sets
additionalProperties: false:

  "^vibrator@[0-9a-f]+$":
    type: object
    $ref: /schemas/input/qcom,pm8xxx-vib.yaml#
  ...
  additionalProperties: false

Because patternProperties in Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
does not include a pattern for "^haptics@[0-9a-f]+$" referencing
/schemas/input/qcom,spmi-haptics.yaml#, will a full dt_binding_check (and
dtbs_check on device trees using this node) fail schema validation on
haptics@f000?

[1] https://lore.kernel.org/r/20260807062927.548EF1F000E9@smtp.kernel.org

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261103-qcom-spmi-haptics-v7-0-418de67ef84a@oss.qualcomm.com?part=1