Re: [PATCH 2/2] pinctrl: Add Siflower SF19A2890 pin controller driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] pinctrl: sf19a2890: Kconfig depends on undefined MACH_SIFLOWER_MIPS
--

commit ac52cbc972a93961baa0d00dc4d81d67b2ec8a72
Author: Joseph Telaak <joseph@telaak.dev>

pinctrl: Add Siflower SF19A2890 pin controller driver

This commit adds a pin controller driver for the Siflower SF19A2890 SoC,
supporting pinmuxing, GPIO mux switching, and pad configuration such as
bias, input enable, Schmitt trigger, and drive strength.

> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index dc7138302c55c..1321eb679fcdd 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -562,6 +562,20 @@ config PINCTRL_SCMI
>  	  It uses SCMI Message Protocol to interact with the
>  	  firmware providing all the pinctrl controls.
>  
> +config PINCTRL_SF19A2890
> +	tristate "Siflower SF19A2890 pin controller"
> +	depends on MACH_SIFLOWER_MIPS || COMPILE_TEST
> +	depends on OF
> +	default MACH_SIFLOWER_MIPS

[Severity: Low]
Is MACH_SIFLOWER_MIPS defined in the tree? Because MACH_SIFLOWER_MIPS does
not exist in any Kconfig file, PINCTRL_SF19A2890 in drivers/pinctrl/Kconfig
cannot be enabled on MIPS configurations unless COMPILE_TEST is set, and
default MACH_SIFLOWER_MIPS always evaluates to n.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261104-sf19a2890-pinctrl-v1-0-4bb83afdbacf@telaak.dev?part=2