From: sashiko-bot@kernel.org
To: "Val Packett" <val@packett.cool>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sc8180x: Add SLPI remoteproc node
Date: Wed, 04 Nov 2026 07:51:02 +0000 [thread overview]
Message-ID: <sashiko-outbox-196833@kernel.org> (raw)
In-Reply-To: <20261104074200.123842-1-val@packett.cool>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] arm64: dts: qcom: sc8180x: remoteproc_slpi compatible violates DT binding
--
commit 0d379b187776a8ea6d877b7ca4de413f6a03989d
Author: Val Packett <val@packett.cool>
arm64: dts: qcom: sc8180x: Add SLPI remoteproc node
This commit adds the Sensors Low-Power Island (SLPI) remoteproc device tree
node to sc8180x.dtsi.
> diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
> index a85e3211958d1..18f03aa62d85e 100644
> --- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
> @@ -2259,6 +2259,67 @@ tcsr_mutex: hwlock@1f40000 {
> #hwlock-cells = <1>;
> };
>
> + remoteproc_slpi: remoteproc@2400000 {
> + compatible = "qcom,sc8180x-slpi-pas", "qcom,sm8150-slpi-pas";
[Severity: Low]
Does this two-entry compatible property pass dtbs_check against
Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml?
In Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml,
qcom,sc8180x-slpi-pas is only permitted as a single standalone enum entry
under properties:compatible:
- enum:
- qcom,sc8180x-adsp-pas
- qcom,sc8180x-cdsp-pas
- qcom,sc8180x-slpi-pas
Additionally, the allOf conditional block in qcom,sm8150-pas.yaml that selects
the lcx and lmx power-domains checks compatible with enum rather than
contains, which does not match a two-item compatible list:
- if:
properties:
compatible:
enum:
- qcom,sc8180x-slpi-pas
- qcom,sm8150-slpi-pas
Looking at qcom_pas_of_match in drivers/remoteproc/qcom_q6v5_pas.c, the other
SC8180X remoteproc nodes use standalone compatible strings, while
qcom,sc8180x-slpi-pas is not yet in the match table:
{ .compatible = "qcom,sc8180x-adsp-pas", .data = &sm8150_adsp_resource },
{ .compatible = "qcom,sc8180x-cdsp-pas", .data = &sm8150_cdsp_resource },
{ .compatible = "qcom,sc8180x-mpss-pas", .data = &sc8180x_mpss_resource },
Should Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml be
updated to allow qcom,sm8150-slpi-pas as a fallback for qcom,sc8180x-slpi-pas
(and use contains in the power-domains conditional), or should remoteproc_slpi
use a single compatible string with qcom,sc8180x-slpi-pas added to
qcom_pas_of_match?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261104074200.123842-1-val@packett.cool?part=1
prev parent reply other threads:[~2026-11-04 7:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 7:40 [PATCH] arm64: dts: qcom: sc8180x: Add SLPI remoteproc node Val Packett
2026-11-04 7:51 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-196833@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=val@packett.cool \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox