From: sashiko-bot@kernel.org
To: "Swamil Jain" <s-jain1@ti.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH] arm64: dts: ti: Add LincolnTech OLDI LCD-185 Overlay for AM67A-BeagleY-AI
Date: Wed, 04 Nov 2026 15:44:35 +0000 [thread overview]
Message-ID: <sashiko-outbox-197531@kernel.org> (raw)
In-Reply-To: <20261104-v1_beagley-ai-lincolntech-lcd185-v1-1-f5daddbbd0a8@ti.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] arm64: dts: ti: unresolved phandles in lcd185 overlay break fdtoverlay build
--
commit 269a825ad2aa2e4a87e4c7338cb6737365bec27a
Author: Swamil Jain <s-jain1@ti.com>
arm64: dts: ti: Add LincolnTech OLDI LCD-185 Overlay for AM67A-BeagleY-AI
This commit adds a device tree overlay and Makefile build rules for the
Lincoln Technology Solutions LCD185-101CT Dual-Link LVDS OLDI panel and
Goodix GT928 touchscreen on the AM67A-BeagleY-AI board.
> diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile
> index da654153a35ba..f7c0b514b3301 100644
> --- a/arch/arm64/boot/dts/ti/Makefile
> +++ b/arch/arm64/boot/dts/ti/Makefile
[ ... ]
> @@ -370,6 +371,8 @@ k3-am67a-beagley-ai-csi0-imx219-dtbs := k3-am67a-beagley-ai.dtb \
> k3-am67a-beagley-ai-csi0-imx219.dtbo
> k3-am67a-beagley-ai-csi1-imx219-dtbs := k3-am67a-beagley-ai.dtb \
> k3-am67a-beagley-ai-csi1-imx219.dtbo
> +k3-am67a-beagley-ai-lincolntech-lcd185-panel-dtbs := k3-am67a-beagley-ai.dtb \
> + k3-am67a-beagley-ai-lincolntech-lcd185-panel.dtbo
> k3-am68-sk-base-board-csi2-dual-imx219-dtbs := k3-am68-sk-base-board.dtb \
> k3-j721e-sk-csi2-dual-imx219.dtbo
> k3-am68-sk-base-board-pcie1-ep-dtbs := k3-am68-sk-base-board.dtb \
> @@ -490,6 +493,7 @@ dtb- += k3-am625-beagleplay-csi2-ov5640.dtb \
> k3-am642-tqma64xxl-mbax4xxl-wlan.dtb \
> k3-am67a-beagley-ai-csi0-imx219.dtb \
> k3-am67a-beagley-ai-csi1-imx219.dtb \
> + k3-am67a-beagley-ai-lincolntech-lcd185-panel.dtb \
> k3-am68-phyboard-izar-lvds-ph128800t006.dtb \
> k3-am68-phyboard-izar-peb-av-15.dtb \
> k3-am68-phyboard-izar-pwm-fan.dtb \
> diff --git a/arch/arm64/boot/dts/ti/k3-am67a-beagley-ai-lincolntech-lcd185-panel.dtso b/arch/arm64/boot/dts/ti/k3-am67a-beagley-ai-lincolntech-lcd185-panel.dtso
> new file mode 100644
> index 0000000000000..8004c058bfb16
> --- /dev/null
> +++ b/arch/arm64/boot/dts/ti/k3-am67a-beagley-ai-lincolntech-lcd185-panel.dtso
> @@ -0,0 +1,199 @@
[ ... ]
> +&dss0 {
> + status = "okay";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + /* VP1: Output to OLDI */
> + port@0 {
> + reg = <0>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + dss0_dpi0_out0: endpoint@0 {
> + reg = <0>;
> + remote-endpoint = <&dss0_oldi0_in>;
> + };
> +
> + dss0_dpi0_out1: endpoint@1 {
> + reg = <1>;
> + remote-endpoint = <&dss0_oldi1_in>;
> + };
> + };
> + };
> +};
> +
> +&dss0_oldi0 {
> + status = "okay";
> + ti,companion-oldi = <&dss0_oldi1>;
[ ... ]
> +&dss0_oldi1 {
> + status = "okay";
> + ti,secondary-oldi;
> + ti,companion-oldi = <&dss0_oldi0>;
[ ... ]
> +&main_i2c1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&main_i2c1_pins_default>;
[Severity: Medium]
Does building k3-am67a-beagley-ai-lincolntech-lcd185-panel.dtb succeed when
CONFIG_OF_ALL_DTBS is enabled?
In arch/arm64/boot/dts/ti/Makefile, adding
k3-am67a-beagley-ai-lincolntech-lcd185-panel-dtbs and adding
k3-am67a-beagley-ai-lincolntech-lcd185-panel.dtb to dtb- causes
scripts/Makefile.dtbs to invoke fdtoverlay to apply
k3-am67a-beagley-ai-lincolntech-lcd185-panel.dtbo onto
k3-am67a-beagley-ai.dtb.
However, the overlay references the labels dss0, dss0_oldi0, dss0_oldi1,
and main_i2c1_pins_default, none of which are defined in
arch/arm64/boot/dts/ti/k3-am67a-beagley-ai.dts or its included J722S dtsi
files in the current tree.
Without the prerequisite BeagleY-AI display changes present in the base
device tree, wouldn't fdtoverlay fail with FDT_ERR_NOTFOUND and break the
build under CONFIG_OF_ALL_DTBS=y or dtbs_check?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261104-v1_beagley-ai-lincolntech-lcd185-v1-1-f5daddbbd0a8@ti.com?part=1
prev parent reply other threads:[~2026-11-04 15:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 15:24 [PATCH] arm64: dts: ti: Add LincolnTech OLDI LCD-185 Overlay for AM67A-BeagleY-AI Swamil Jain
2026-11-04 15:44 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-197531@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s-jain1@ti.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox