Re: [PATCH 1/4] dt-bindings: i2c: qcom-cci: Document SM8150 compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: i2c: qcom-cci: missing allOf clock constraints for sm8150
--

commit aefd954e17156282727d64e6f6e3ba7607d36440
Author: Andrew Gigena <mail@andrewgigena.dev>

dt-bindings: i2c: qcom-cci: Document SM8150 compatible

This commit adds qcom,sm8150-cci to the list of CCI v2 compatible strings
with qcom,msm8996-cci as a fallback.

> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> index 1e8def25ec0ec..b545fd2378dae 100644
> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> @@ -39,6 +39,7 @@ properties:
>                - qcom,shikra-cci
>                - qcom,sm6150-cci
>                - qcom,sm6350-cci
> +              - qcom,sm8150-cci

[Severity: Low]
Should qcom,sm8150-cci also be added to the 5-clock conditional under allOf
in Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml?

At the top level, clocks and clock-names only specify minItems: 2 and
maxItems: 6 without listing the allowed clock-names items. The
qcom,msm8996-cci rule under allOf uses const: qcom,msm8996-cci rather than
contains, so it only matches when qcom,msm8996-cci is used alone and does
not apply when paired with qcom,sm8150-cci.

Without adding qcom,sm8150-cci to the allOf conditional block alongside
qcom,sc7280-cci, qcom,sm8250-cci, and qcom,sm8450-cci:

  - if:
      properties:
        compatible:
          contains:
            enum:
              - qcom,sc7280-cci
              - qcom,sm8250-cci
              - qcom,sm8450-cci
    then:
      properties:
        clocks:
          minItems: 5
          maxItems: 5
        clock-names:
          items:
            - const: camnoc_axi
            - const: slow_ahb_src
            - const: cpas_ahb
            - const: cci
            - const: cci_src

dtbs_check will not constrain the clock count or clock-names list for
qcom,sm8150-cci nodes.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261104-sm8150-v7-4-rc1-camss-v1-0-7a9534a9a22f@andrewgigena.dev?part=1