Re: [PATCH net-next v5 1/7] dt-bindings: net: ftgmac100: Make Aspeed compatibles standalone

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: net: ftgmac100: dropping fallback compatible breaks dtbs_check
--

commit 95571d7f339ca9cf43fcba9a2d07a1737a0162eb
Author: Jacky Chou <jacky_chou@aspeedtech.com>

dt-bindings: net: ftgmac100: Make Aspeed compatibles standalone

This commit changes the Aspeed MAC compatibles in
Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml from requiring
the generic faraday,ftgmac100 fallback string to being standalone compatibles.

> diff --git a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> index d14410018bcf6..c870dd0bda7b2 100644
> --- a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> +++ b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> @@ -13,12 +13,10 @@ properties:
>    compatible:
>      oneOf:
>        - const: faraday,ftgmac100
> -      - items:
> -          - enum:
> -              - aspeed,ast2400-mac
> -              - aspeed,ast2500-mac
> -              - aspeed,ast2600-mac
> -          - const: faraday,ftgmac100
> +      - enum:
> +          - aspeed,ast2400-mac
> +          - aspeed,ast2500-mac
> +          - aspeed,ast2600-mac

[Severity: Medium]
As reported by Rob Herring on v4 [1], does removing the two-item compatible
entry from properties.compatible in
Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml break DT schema
backward compatibility and cause dtbs_check regressions for existing device
trees?

In-tree device trees in arch/arm/boot/dts/aspeed/aspeed-g4.dtsi,
arch/arm/boot/dts/aspeed/aspeed-g5.dtsi, and
arch/arm/boot/dts/aspeed/aspeed-g6.dtsi still declare their MAC nodes with the
two-string compatible form, such as:

    compatible = "aspeed,ast2600-mac", "faraday,ftgmac100";

When running make dtbs_check, every board that includes those .dtsi files will
fail validation against faraday,ftgmac100.yaml because the two-item list is no
longer permitted by the schema.

Should the existing two-item compatible entry be retained (for example marked
with deprecated: true) alongside the standalone enum so that existing device
trees continue to validate cleanly without introducing dtbs_check warnings?

[1] https://lore.kernel.org/r/20261020181441.GA510274-robh@kernel.org

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261104-support_ast2700-v5-0-44057f4dde75@aspeedtech.com?part=1