Re: [PATCH net-next 2/2] net: stmmac: Add Siflower SF19A2890 glue

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] net: stmmac: DWMAC_SF19A2890 depends on undefined Kconfig symbol MACH_SIFLOWER_MIPS
--

commit 525b363248f5ebf2554b1d2d37b10b76ddf73d26
Author: Joseph Telaak <joseph@telaak.dev>

net: stmmac: Add Siflower SF19A2890 glue

This commit adds the stmmac platform glue driver for the DesignWare GMAC on
the Siflower SF19A2890 SoC, configuring the PHY interface mode and RGMII
internal clock delays.

> diff --git a/drivers/net/ethernet/stmicro/stmmac/Kconfig b/drivers/net/ethernet/stmicro/stmmac/Kconfig
> index c6559e749c0ce..78efe78590220 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/Kconfig
> +++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig
> @@ -201,6 +201,17 @@ config DWMAC_S32
>  	  SOCs GMAC ethernet controller, ie. S32G2xx, S32G3xx and
>  	  S32R45.
>  
> +config DWMAC_SF19A2890
> +	tristate "Siflower SF19A2890 GMAC support"
> +	default MACH_SIFLOWER_MIPS
> +	depends on OF && (MACH_SIFLOWER_MIPS || COMPILE_TEST)

[Severity: Medium]
In drivers/net/ethernet/stmicro/stmmac/Kconfig, the DWMAC_SF19A2890 entry
references MACH_SIFLOWER_MIPS in both its default and depends on lines.

However, MACH_SIFLOWER_MIPS is not defined in any Kconfig file in the tree.
Because undefined Kconfig symbols always evaluate to n, the default never
activates and DWMAC_SF19A2890 cannot be selected unless COMPILE_TEST is
enabled.

Is there a missing architecture Kconfig patch defining MACH_SIFLOWER_MIPS, or
should this depend on a different symbol?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261104-sf19a2890-gmac-v1-0-a15965a49574@telaak.dev?part=2