Re: [PATCH V6 1/3] arm64: dts: qcom: monaco: Move eMMC CQE support from SoC to board DT

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] arm64: dts: qcom: monaco: missing supports-cqe on sdhc_1 in monaco-ac-evk.dts
--

commit 5c417a101ec7d48bcf62abc40a54fc7490862bc8
Author: Monish Chunara <monish.chunara@oss.qualcomm.com>

arm64: dts: qcom: monaco: Move eMMC CQE support from SoC to board DT

This commit removes the supports-cqe property from the shared SoC sdhc_1 node
in monaco.dtsi to avoid conflicts with SD card operation, and adds it
explicitly to the qcs8300-ride.dts and monaco-monza-som.dtsi board device
trees.

> diff --git a/arch/arm64/boot/dts/qcom/monaco.dtsi b/arch/arm64/boot/dts/qcom/monaco.dtsi
> index 35fbee63d4c65..591ad233f90eb 100644
> --- a/arch/arm64/boot/dts/qcom/monaco.dtsi
> +++ b/arch/arm64/boot/dts/qcom/monaco.dtsi
> @@ -4843,7 +4843,6 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
>  			qcom,dll-config = <0x000f64ee>;
>  			qcom,ddr-config = <0x80040868>;
>  			bus-width = <8>;
> -			supports-cqe;

[Severity: Medium]
Should supports-cqe also be added to &sdhc_1 in
arch/arm64/boot/dts/qcom/monaco-ac-evk.dts?

While the follow-up patches in this series ("arm64: dts: qcom: monaco-evk:
Enable SDHCI for SD Card via overlay" and "arm64: dts: qcom: monaco-evk: Add
SDHCI support for eMMC via overlay") move &sdhc_1 out of monaco-evk.dts into
monaco-evk-emmc.dtso with supports-cqe, monaco-ac-evk.dts is not updated in
the series.

monaco-ac-evk.dts includes monaco.dtsi and enables &sdhc_1 directly in fixed
1.8V eMMC mode:

arch/arm64/boot/dts/qcom/monaco-ac-evk.dts:
&sdhc_1 {
	vmmc-supply = <&vreg_l8a>;
	vqmmc-supply = <&vreg_s2s>;

	no-sd;
	no-sdio;
	non-removable;

	status = "okay";
};

Without supports-cqe on &sdhc_1 in monaco-ac-evk.dts, sdhci_msm_probe() in
drivers/mmc/host/sdhci-msm.c takes the non-CQE path:

	if (of_property_read_bool(node, "supports-cqe"))
		ret = sdhci_msm_cqe_add_host(host, pdev);
	else
		ret = sdhci_add_host(host);

Wouldn't removing supports-cqe from monaco.dtsi without adding it to
monaco-ac-evk.dts cause sdhci_msm_probe() to skip sdhci_msm_cqe_add_host()
and sdhci_msm_ice_init(), disabling both CQE and inline encryption (qcom,ice)
on the Monaco-AC EVK board?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261105101955.3732723-1-monish.chunara@oss.qualcomm.com?part=1