Re: [PATCH v3 1/3] dt-bindings: media: i2c: dw9800: Redocument DW9800K

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: media: dw9800k: misspelled dongwoon,vcm-presc in example
--

commit f9bb5305dbf06d2a36be417b4c7b389a82ea4850
Author: Griffin Kroah-Hartman <griffin.kroah@fairphone.com>

dt-bindings: media: i2c: dw9800: Redocument DW9800K

This commit moves the Dongwoon Anatech DW9800K binding out of
dongwoon,dw9719.yaml into its own dongwoon,dw9800k.yaml schema file with
updated SAC mode, vcm-prescale, and timing-control properties.

> diff --git a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9800k.yaml b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9800k.yaml
> new file mode 100644
> index 0000000000000..f5bae7b287f1b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9800k.yaml
> @@ -0,0 +1,91 @@

[ ... ]

> +  dongwoon,vcm-prescale:
> +    description:
> +      Indication of VCM internal clock dividing rate select, as one multiple
> +      factor to calculate VCM ring periodic time Tvib.
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum:
> +      - 0 #  Dividing Rate -  2
> +      - 1 #  Dividing Rate -  1
> +      - 2 #  Dividing Rate -  1/2
> +      - 3 #  Dividing Rate -  1/4
> +      - 4 #  Dividing Rate -  8
> +      - 5 #  Dividing Rate -  4
> +    default: 1

[ ... ]

> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        actuator@c {
> +            compatible = "dongwoon,dw9800k";
> +            reg = <0x0c>;
> +
> +            vdd-supply = <&pm8937_l17>;
> +
> +            dongwoon,sac-mode = <4>;
> +            dongwoon,vcm-presc = <0>;

[Severity: Low]
In the examples section of dongwoon,dw9800k.yaml, the actuator@c node uses
dongwoon,vcm-presc, whereas the schema properties section defines
dongwoon,vcm-prescale and sets additionalProperties to false.

Should this be dongwoon,vcm-prescale = <0>; so that make dt_binding_check
passes?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261105-b4-dw9800k_cleanup-v3-0-6850ee6a5a5a@fairphone.com?part=1