Re: [PATCH v2] ARM: dts: nxp/imx6: Drop unused .dtsi

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] ARM: dts: imx6: Deleting Dwarf and Nymph .dtsi omitted by copy-paste in .dts
--

commit 22f4920daa7995325841819b6b25c37d2efd2b30
Author: Rob Herring (Arm) <robh@kernel.org>

ARM: dts: nxp/imx6: Drop unused .dtsi

This commit removes four i.MX6 device tree include files that are not
currently included by any in-tree device tree sources.

> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-dwarf.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-dwarf.dtsi
> deleted file mode 100644
> index 3a968782e854b..0000000000000
> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-dwarf.dtsi
> +++ /dev/null
> @@ -1,45 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0+ OR MIT
> -//
> -// Copyright 2017 NXP
> -
> -#include "imx6qdl-pico.dtsi"

[ ... ]

> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-nymph.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-nymph.dtsi
> deleted file mode 100644
> index 3d56a42164482..0000000000000
> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-nymph.dtsi
> +++ /dev/null
> @@ -1,54 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0+ OR MIT
> -
> -#include "imx6qdl-pico.dtsi"

[Severity: Medium]
Should imx6qdl-pico-dwarf.dtsi and imx6qdl-pico-nymph.dtsi be wired up to
their existing board device trees instead of being deleted?

Unlike the Kontron files, the corresponding board files for Dwarf and Nymph
already exist in the tree and are built by arch/arm/boot/dts/nxp/imx/Makefile
(imx6dl-pico-dwarf.dts, imx6q-pico-dwarf.dts, imx6dl-pico-nymph.dts, and
imx6q-pico-nymph.dts).

When commit 98670a0bb0ef ("ARM: dts: imx6qdl: Add imx6qdl-pico support")
added support for the Dwarf, Hobbit, Nymph, and Pi baseboards, a copy-paste
error left the Dwarf and Nymph .dts files including imx6qdl-pico-pi.dtsi:

arch/arm/boot/dts/nxp/imx/imx6dl-pico-dwarf.dts:
    #include "imx6dl.dtsi"
    #include "imx6qdl-pico-pi.dtsi"

    / {
            model = "TechNexion PICO-IMX6 DualLite/Solo Board and Dwarf baseboard";
            compatible = "technexion,imx6dl-pico-dwarf", "fsl,imx6dl";
    };

arch/arm/boot/dts/nxp/imx/imx6dl-pico-nymph.dts:
    #include "imx6dl.dtsi"
    #include "imx6qdl-pico-pi.dtsi"

    / {
            model = "TechNexion PICO-IMX6 DualLite/Solo Board and Nymph baseboard";
            compatible = "technexion,imx6dl-pico-nymph", "fsl,imx6dl";
    };

(and similarly in imx6q-pico-dwarf.dts and imx6q-pico-nymph.dts).

As a result, the Dwarf and Nymph board DTBs are currently built with the Pi
baseboard description (which disables HDMI and routes the LED to GPIO5_IO18)
rather than their own baseboard descriptions in imx6qdl-pico-dwarf.dtsi
(GPIO5_IO31 LED, mpl3115@60 on i2c1, and pca9554 io-expander@25 on i2c2) and
imx6qdl-pico-nymph.dtsi (GPIO5_IO31 LED, adc@52 on i2c1, pca9554
io-expander@25 on i2c2, ds1337 rtc@68 on i2c3, and PCIe enabled).

Would it make sense to keep imx6qdl-pico-dwarf.dtsi and
imx6qdl-pico-nymph.dtsi and update the four Dwarf and Nymph .dts files to
include them?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261105144920.2796623-2-robh@kernel.org?part=1