Re: [PATCH 2/2] phy: siflower: Add SF19A2890 USB 2.0 PHY driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] phy: siflower: undefined Kconfig dependency MACH_SIFLOWER_MIPS
--

commit c44d6ed3118eced71fa2b4f04b0e4dd618bdded3
Author: Chuanhong Guo <gch981213@gmail.com>

phy: siflower: Add SF19A2890 USB 2.0 PHY driver

This commit adds a driver for the USB 2.0 PHY of the Siflower SF19A2890 SoC,
handling its reference clock, power-on and PHY resets, and sleep mode register.

> diff --git a/drivers/phy/siflower/Kconfig b/drivers/phy/siflower/Kconfig
> new file mode 100644
> index 0000000000000..5ae1f83d14494
> --- /dev/null
> +++ b/drivers/phy/siflower/Kconfig
> @@ -0,0 +1,12 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +
> +config PHY_SF19A2890_USB
> +	tristate "Siflower SF19A2890 USB 2.0 PHY driver"
> +	depends on MACH_SIFLOWER_MIPS || COMPILE_TEST

[Severity: Medium]
Is MACH_SIFLOWER_MIPS defined in the Kconfig tree?

Because MACH_SIFLOWER_MIPS does not exist in arch/mips/ or elsewhere in the
tree, Kconfig evaluates it to n and prevents PHY_SF19A2890_USB from being
enabled unless COMPILE_TEST is set.

Should this depend on MIPS || COMPILE_TEST (or MIPS_GENERIC_KERNEL) until
the platform Kconfig symbol is introduced?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261104-sf19a2890-usb-phy-v1-0-db0cad937614@telaak.dev?part=2