Re: [PATCH v8 2/7] dt-bindings: iio: imu: icm42600: Add ICM-42670-P

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: iio: imu: commit title names ICM-42670-P instead of ICM-42370-P
--

commit ee05c3444a8f259324760f6fbb66f8234e85b9e5
Author: Kanak Shilledar <kanak.shilledar@axis.com>

dt-bindings: iio: imu: icm42600: Add ICM-42670-P

This commit adds the TDK InvenSense ICM-42370-P 3-axis accelerometer to the
invensense,icm42600 Devicetree binding schema and updates the binding
description accordingly.

>     dt-bindings: iio: imu: icm42600: Add ICM-42670-P
>     
>     TDK Invensense, ICM-42370-P is a 3-axis accelerometer. The device can
>     support I2C, SPI and I3C. This device only has an accelerometer and
>     lacks gyroscope and it has very similar properties as that of the
>     icm42607/p the gyroscope feature is controlled via the driver depending
>     on the device. Add this device to the existing dt-binding and update the
>     description to match the devices.
>     
>     Datasheet: https://www.invensense.tdk.com/en-us/products/3-axis/icm-42370-p
>     Signed-off-by: Kanak Shilledar <kanak.shilledar@axis.com>
>
> diff --git a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml
> index 8d16421c6f82e..7c5f42f384672 100644
> --- a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml
> +++ b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml
> @@ -11,10 +11,11 @@ maintainers:
>  
>  description: |
>    6-axis MotionTracking device that combines a 3-axis gyroscope and a 3-axis
> -  accelerometer.
> +  accelerometer. Some devices such as the Invensense, ICM-42370-P only has a
> +  3-axis accelerometer.
>  
>    It has a configurable host interface that supports I3C, I2C and SPI serial
> -  communication, features a 2kB FIFO and 2 programmable interrupts with
> +  communication, features up to 2.25kB FIFO and 2 programmable interrupts with
>    ultra-low-power wake-on-motion support to minimize system power consumption.
>  
>    Other industry-leading features include InvenSense on-chip APEX Motion
> @@ -28,6 +29,7 @@ properties:
>    compatible:
>      oneOf:
>        - enum:
> +          - invensense,icm42370p
>            - invensense,icm42600
>            - invensense,icm42602
>            - invensense,icm42605

[Severity: Low]
This isn't a bug, but should the commit subject reference ICM-42370-P instead
of ICM-42670-P?

Both the commit message body and the changes to description and
properties.compatible in
Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml add
invensense,icm42370p (ICM-42370-P) rather than ICM-42670-P.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261105-b4-inv_icm42370p-v8-0-b44eb96020b6@axis.com?part=2