Re: [PATCH 1/3] ARM: dts: aspeed: ventura2: Add LTC2305 ADCs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] ARM: dts: aspeed: ventura2: missing vref-supply violates lltc,ltc2497.yaml
--

commit 13d509351ee73dbf947376a477d0e32c8ab7eea1
Author: Kyle Hsieh <kylehsieh1995@gmail.com>

ARM: dts: aspeed: ventura2: Add LTC2305 ADCs

This commit adds three lltc,ltc2305 ADC nodes to the Facebook Ventura2 BMC
device tree (under i2c0mux0ch2 and i2c3) without vref-supply properties and
wires the i2c3 channels into iio-hwmon.

> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dts
> index f3dbdece30767..50e652cc37a17 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dts

[ ... ]

> @@ -392,6 +393,12 @@ i2c0mux0ch2: i2c@2 {
>  			reg = <2>;
>  			#address-cells = <1>;
>  			#size-cells = <0>;
> +
> +			adc@8 {
> +				compatible = "lltc,ltc2305";
> +				reg = <0x08>;
> +				#io-channel-cells = <1>;
> +			};
>  		};
>  
>  		i2c0mux0ch3: i2c@3 {
> @@ -583,6 +590,18 @@ &i2c3 {
>  
>  	status = "okay";
>  
> +	adc_op_fb1: adc@8 {
> +		compatible = "lltc,ltc2305";
> +		reg = <0x08>;
> +		#io-channel-cells = <1>;
> +	};
> +
> +	adc_op_fb2: adc@9 {
> +		compatible = "lltc,ltc2305";
> +		reg = <0x09>;
> +		#io-channel-cells = <1>;
> +	};

[Severity: Low]
Although ltc2309_probe() in drivers/iio/adc/ltc2309.c treats vref-supply as
optional and falls back to LTC2309_INTERNAL_REF_MV when it is absent, the
binding schema in Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml
unconditionally requires vref-supply:

required:
  - compatible
  - reg
  - vref-supply

Doesn't omitting vref-supply on adc@8 under i2c0mux0ch2 and on adc_op_fb1 and
adc_op_fb2 under i2c3 cause make dtbs_check validation errors on
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura2.dtb unless
Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml is updated first
to make vref-supply optional for lltc,ltc2305 and lltc,ltc2309?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106-ventura2-dts-update-v1-0-b085ece9bf57@gmail.com?part=1