From: sashiko-bot@kernel.org
To: "Nihal Kumar Gupta" <nihal.gupta@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, linux-phy@lists.infradead.org,
robh@kernel.org, conor+dt@kernel.org, media-ci@linuxtv.org,
vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com
Subject: Re: [PATCH v4 1/6] dt-bindings: i2c: qcom,i2c-cci: Add Hawi compatible
Date: Fri, 06 Nov 2026 06:57:37 +0000 [thread overview]
Message-ID: <sashiko-outbox-200949@kernel.org> (raw)
In-Reply-To: <20261106-hawi-maili-camss-v4-1-d528c7a797b4@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] dt-bindings: i2c: qcom,hawi-cci falls back to
qcom,msm8996-cci
--
commit eeb66a38f27dd112905efa0a186dff7682ef33dd
Author: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>
dt-bindings: i2c: qcom,i2c-cci: Add Hawi compatible
This commit documents the qcom,hawi-cci compatible string and its
two-clock requirement in the Qualcomm CCI I2C binding.
> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> index 1e8def25ec0ec..b2b4d4bcf7807 100644
> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> @@ -27,6 +27,7 @@ properties:
> - items:
> - enum:
> - qcom,glymur-cci
> + - qcom,hawi-cci
> - qcom,kaanapali-cci
> - qcom,milos-cci
> - qcom,qcm2290-cci
[Severity: Medium]
As reported by Loic Poulain on RFC [1], should qcom,hawi-cci stop falling
back to qcom,msm8996-cci and use a dedicated variant entry instead?
Placing qcom,hawi-cci in the qcom,msm8996-cci fallback list without a
dedicated entry in cci_dt_match[] causes cci_probe() to bind Hawi CCI
controllers to the legacy cci_v2_data configuration (queue_size = { 64, 16 }
and max_write_len = 11) rather than matching the newer IP revision's FIFO
and queue sizes.
[1] https://lore.kernel.org/r/CAFEp6-1Zvt0hhBd7LNx2hsyi9J+bxCT8EWN3jZ4B30SO58SCow@mail.gmail.com
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261106-hawi-maili-camss-v4-0-d528c7a797b4@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-11-06 6:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 6:50 [PATCH v4 0/6] Add CAMSS support for Qualcomm Hawi and Maili Nihal Kumar Gupta
2026-11-06 6:50 ` [PATCH v4 1/6] dt-bindings: i2c: qcom,i2c-cci: Add Hawi compatible Nihal Kumar Gupta
2026-11-06 6:57 ` sashiko-bot [this message]
2026-11-06 6:50 ` [PATCH v4 2/6] dt-bindings: phy: qcom,x1e80100-csi2-phy: Add Hawi and Maili compatibles Nihal Kumar Gupta
2026-11-06 6:50 ` [PATCH v4 3/6] dt-bindings: media: Add CAMSS device for Hawi and Maili Nihal Kumar Gupta
2026-11-06 6:50 ` [PATCH v4 4/6] phy: qcom-mipi-csi2: Add Hawi support Nihal Kumar Gupta
2026-11-06 6:50 ` [PATCH v4 5/6] media: qcom: camss: csid: Scale the clocks with the CSI-2 link rate Nihal Kumar Gupta
2026-11-06 6:50 ` [PATCH v4 6/6] media: qcom: camss: Add support for Hawi Nihal Kumar Gupta
2026-11-06 7:12 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-200949@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=media-ci@linuxtv.org \
--cc=neil.armstrong@linaro.org \
--cc=nihal.gupta@oss.qualcomm.com \
--cc=olteanv@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox