Re: [PATCH 4/5] arm64: dts: rockchip: Add DSI panel to RK3588 EVB1

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] arm64: dts: rockchip: missing irq-gpios in rk3588-evb1 gt1x
  node
--

commit 835c4b16ada6b31743a047c67f574eb288523de2
Author: Sebastian Reichel <sebastian.reichel@collabora.com>

arm64: dts: rockchip: Add DSI panel to RK3588 EVB1

This commit adds Device Tree nodes for the Wanchanglong W552793BAA DSI
panel and Goodix GT1158 touchscreen on the RK3588 EVB1 board.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
> index 6a95a8bb6fb80..327ca13b60f09 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts

[ ... ]

> @@ -495,6 +541,22 @@ hym8563: rtc@51 {
>  	};
>  };
>  
> +&i2c6 {
> +	status = "okay";
> +
> +	gt1x: touchscreen@14 {
> +		compatible = "goodix,gt1158";
> +		reg = <0x14>;
> +		interrupt-parent = <&gpio0>;
> +		interrupts = <RK_PD3 IRQ_TYPE_LEVEL_LOW>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&touchscreen_pins>;
> +		reset-gpios = <&gpio0 RK_PD2 GPIO_ACTIVE_HIGH>;
> +		AVDD28-supply = <&vcc3v3_lcd_mipi>;
> +		VDDIO-supply = <&vcc3v3_lcd_mipi>;
> +	};
> +};

[Severity: Medium]
Should gt1x also specify irq-gpios = <&gpio0 RK_PD3 GPIO_ACTIVE_HIGH>?

In drivers/input/touchscreen/goodix.c:goodix_get_gpio_config(), the driver
requires both irq-gpios and reset-gpios to enable GPIO pin control:

drivers/input/touchscreen/goodix.c:goodix_get_gpio_config() {
	...
	default:
		if (ts->gpiod_int && ts->gpiod_rst) {
			ts->reset_controller_at_probe = true;
			ts->load_cfg_from_disk = true;
			ts->irq_pin_access_method = IRQ_PIN_ACCESS_GPIO;
		}
	}
}

Without irq-gpios, ts->gpiod_rst is left in GPIOD_ASIS and never used,
preventing goodix_reset_no_int_sync() from resetting the controller and
strapping the INT pin to select I2C address 0x14, and leaving
ts->irq_pin_access_method as IRQ_PIN_ACCESS_NONE so goodix_suspend() and
goodix_resume() become no-ops.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106-rk3588-evb1-dt-updates-v1-0-bdbe16223589@collabora.com?part=4