From: sashiko-bot@kernel.org
To: "Dileep Kumar Nagavarapu" <dileepkumar.nagavarapu@amd.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v5] dt-bindings: iio: adc: Convert xilinx-xadc bindings to YAML schema
Date: Sat, 07 Nov 2026 13:56:36 +0000 [thread overview]
Message-ID: <sashiko-outbox-202934@kernel.org> (raw)
In-Reply-To: <20261107134955.1423727-1-dileepkumar.nagavarapu@amd.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: iio: adc: xlnx,xadc: commit log describes
inter-revision changes
--
commit d68c424577a43ba2a1a0878e11b74b4e72fd8ee2
Author: Pramod Maurya <pramod.nexgen@gmail.com>
dt-bindings: iio: adc: Convert xilinx-xadc bindings to YAML schema
This commit converts the Xilinx XADC and UltraScale System Monitor device
tree binding from plain text to a YAML schema and adds a MAINTAINERS entry
for the driver.
> Move xlnx,channels under properties, as dt-schema now allows node names
> containing a comma for long-established bindings.Constrain the reg
> property of the channel subnodes to the valid channel range of 0 to
> 16 with minimum and maximum.
>
> Drop the redundant "type: boolean" from xlnx,bipolar, since its $ref to
> the flag type already implies it.
[Severity: Low]
This isn't a bug, but these two paragraphs describe changes between earlier
versions of this patch rather than changes against the repository, where no
prior YAML schema existed. They belong in the revision changelog below the
"---" line rather than the permanent commit message (and there is a missing
space before "Constrain").
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261107134955.1423727-1-dileepkumar.nagavarapu@amd.com?part=1
next prev parent reply other threads:[~2026-11-07 13:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 13:49 [PATCH v5] dt-bindings: iio: adc: Convert xilinx-xadc bindings to YAML schema Dileep Kumar Nagavarapu
2026-11-07 13:56 ` sashiko-bot [this message]
2026-11-07 19:26 ` Jonathan Cameron
2026-11-10 18:40 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-202934@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dileepkumar.nagavarapu@amd.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox