Re: [PATCH v3 4/4] iio: light: ltr501: Add support for the LTR-659PS-01 proximity sensor

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] iio: light: ltr501: call to unexported
  iio_find_channel_from_si() breaks module build
--

commit a70950dbacecbff02b036d8bf018419c3106a456
Author: Svyatoslav Ryhel <clamor95@gmail.com>

iio: light: ltr501: Add support for the LTR-659PS-01 proximity sensor

This commit adds support for the Lite-On LTR-659PS-01 proximity-only
sensor, introduces a no_als_support flag to skip ALS register accesses,
and updates ltr501_trigger_handler() to inspect channel types rather than
fixed scan indices.

> diff --git a/drivers/iio/light/ltr501.c b/drivers/iio/light/ltr501.c
> index ca6c8cffb4001..b97b8da98e86c 100644
> --- a/drivers/iio/light/ltr501.c
> +++ b/drivers/iio/light/ltr501.c

[ ... ]

> @@ -1260,16 +1295,21 @@ static irqreturn_t ltr501_trigger_handler(int irq, void *p)
>  		aligned_s64 ts;
>  	} scan = { };
>  	__le16 als_buf[2];
> +	unsigned int i;
>  	u8 mask = 0;
>  	int j = 0;
>  	int ret, psdata;
>  
>  	/* figure out which data needs to be ready */
> -	if (test_bit(0, indio_dev->active_scan_mask) ||
> -	    test_bit(1, indio_dev->active_scan_mask))
> -		mask |= LTR501_STATUS_ALS_RDY;
> -	if (test_bit(2, indio_dev->active_scan_mask))
> -		mask |= LTR501_STATUS_PS_RDY;
> +	for_each_set_bit(i, indio_dev->active_scan_mask, indio_dev->num_channels) {
> +		const struct iio_chan_spec *chan = iio_find_channel_from_si(indio_dev, i);
> +
> +		if (chan->type == IIO_INTENSITY)
> +			mask |= LTR501_STATUS_ALS_RDY;
> +
> +		if (chan->type == IIO_PROXIMITY)
> +			mask |= LTR501_STATUS_PS_RDY;
> +	}

[Severity: High]
Does calling iio_find_channel_from_si() break the build when
CONFIG_LTR501=m?

iio_find_channel_from_si() in drivers/iio/industrialio-core.c is not
exported with EXPORT_SYMBOL_GPL(), so linking ltr501.ko fails at modpost
with an undefined symbol error.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261108094253.83899-1-clamor95@gmail.com?part=4