Re: [PATCH v3 08/10] arm64: dts: qcom: sdm845-samsung-starqltechn: Update panel compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: qcom: incompatible panel@0 compatible and
  reset-gpios change
--

commit 73ab76c040fc6673b910317ac87e836c9478306e
Author: David Heidelberg <david@ixit.cz>

arm64: dts: qcom: sdm845-samsung-starqltechn: Update panel compatible

This commit replaces the panel@0 compatible string with
"samsung,s6e3ha8-amb577px01" and changes reset-gpios to GPIO_ACTIVE_LOW in
sdm845-samsung-starqltechn.dts.

> diff --git a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
> index bd59f1dcd96dc..c156ed3733b4e 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
> @@ -267,13 +267,13 @@ &mdss_dsi0 {
>  	status = "okay";
>  
>  	panel@0 {
> -		compatible = "samsung,s6e3ha8";
> +		compatible = "samsung,s6e3ha8-amb577px01";
>  		reg = <0>;
>  		vci-supply = <&s2dos05_ldo4>;
>  		vddr-supply = <&s2dos05_buck>;
>  		vdd3-supply = <&s2dos05_ldo1>;
>  		te-gpios = <&tlmm 10 GPIO_ACTIVE_HIGH>;
> -		reset-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>;
> +		reset-gpios = <&tlmm 6 GPIO_ACTIVE_LOW>;

[Severity: High]
As reported by Krzysztof Kozlowski on v2 [1], does replacing the
"samsung,s6e3ha8" compatible string and inverting reset-gpios break DTB ABI
compatibility for existing kernels and DTB consumers?

Existing kernels and trees that only match "samsung,s6e3ha8" and expect
GPIO_ACTIVE_HIGH (introduced in 70005c18c9f7 ("arm64: dts: qcom:
sdm845-starqltechn: add graphics support")) will no longer bind or reset
panel@0 when booted with this DTB, while the panel driver already handles
the legacy compatible and polarity via broken_reset_polarity.

[1] https://lore.kernel.org/r/20260929-spirited-umber-hedgehog-300ebd@quoll

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261108-crosshatch-panel-v3-0-87dd4ec4f7cc@ixit.cz?part=8