Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Pufan Jin" <cyan2254650260@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: soc: xilinx: Add ALINX AX7Z020B board
Date: Sun, 08 Nov 2026 21:59:34 +0000	[thread overview]
Message-ID: <sashiko-outbox-204101@kernel.org> (raw)
In-Reply-To: <20261108215010.351256-2-cyan2254650260@gmail.com>

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] dt-bindings: soc: xilinx: undocumented alinx vendor prefix
- [Low] dt-bindings: soc: xilinx: standalone board entry for
  alinx,ac7z020 SoM
--

commit 1e47b64f622951246602cf5bda819bb5e711a84e
Author: Pufan Jin <cyan2254650260@gmail.com>

dt-bindings: soc: xilinx: Add ALINX AX7Z020B board

This commit documents the compatible strings for the ALINX AX7Z020B
development board and the ALINX AC7Z020 system on module in the Xilinx SoC
binding schema.

Link: https://www.alinx.com/

> diff --git a/Documentation/devicetree/bindings/soc/xilinx/xilinx.yaml b/Documentation/devicetree/bindings/soc/xilinx/xilinx.yaml
> index 5f33f7def6a32..349987962e33f 100644
> --- a/Documentation/devicetree/bindings/soc/xilinx/xilinx.yaml
> +++ b/Documentation/devicetree/bindings/soc/xilinx/xilinx.yaml
> @@ -20,6 +20,7 @@ properties:
>        - items:
>            - enum:
>                - adapteva,parallella
> +              - alinx,ac7z020

[Severity: Low]
Should alinx,ac7z020 be listed in this two-item standalone board enum?
AC7Z020 is a System on Module (.dtsi) that cannot boot without a carrier
board, and the three-item entry below already covers the AX7Z020B carrier
board paired with the AC7Z020 SoM.

>                - digilent,zynq-zybo
>                - digilent,zynq-zybo-z7
>                - ebang,ebaz4205
> @@ -34,6 +35,11 @@ properties:
>                - xlnx,zynq-zc770-xm013
>            - const: xlnx,zynq-7000
>  
> +      - items:
> +          - const: alinx,ax7z020b
> +          - const: alinx,ac7z020
> +          - const: xlnx,zynq-7000

[Severity: Low]
Does the "alinx" vendor prefix need to be added to
Documentation/devicetree/bindings/vendor-prefixes.yaml?  Without an entry
there, running make dt_binding_check or scripts/checkpatch.pl reports an
undocumented vendor prefix for alinx,ax7z020b and alinx,ac7z020.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261108215010.351256-1-cyan2254650260@gmail.com?part=1

  reply	other threads:[~2026-11-08 21:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-08 21:50 [PATCH 0/2] ARM: dts: zynq: Add ALINX AX7Z020B development board Pufan Jin
2026-11-08 21:50 ` [PATCH 1/2] dt-bindings: soc: xilinx: Add ALINX AX7Z020B board Pufan Jin
2026-11-08 21:59   ` sashiko-bot [this message]
2026-11-08 21:50 ` [PATCH 2/2] ARM: dts: zynq: Add ALINX AX7Z020B development board Pufan Jin
2026-11-08 22:01   ` sashiko-bot
2026-11-11  2:17   ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-204101@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=cyan2254650260@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox