Re: [PATCH 4/5] clk: qcom: common: Register clk_ref clocks from qcom_cc_desc

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] clk: qcom: qcom_cc_clk_hw_get() returns -EINVAL for protected
  clk_ref
--

commit fa96d79cffd1dd43d975e203514d31dbe847897b
Author: Stanislav Aleksandrov <lightofmysoul@gmail.com>

clk: qcom: common: Register clk_ref clocks from qcom_cc_desc

This commit adds support for registering clk_ref clocks from a
qcom_cc_desc descriptor alongside standard regmap clocks in
qcom_cc_really_probe().

> diff --git a/drivers/clk/qcom/common.c b/drivers/clk/qcom/common.c
> index 08fd62ac780d3..c767fa3d02079 100644
> --- a/drivers/clk/qcom/common.c
> +++ b/drivers/clk/qcom/common.c
[ ... ]
> @@ -247,6 +250,9 @@ static struct clk_hw *qcom_cc_clk_hw_get(struct of_phandle_args *clkspec,
>  	struct qcom_cc *cc = data;
>  	unsigned int idx = clkspec->args[0];
>  
> +	if (idx < cc->num_clk_refs && cc->clk_refs[idx])
> +		return &cc->clk_refs[idx]->hw;
> +
>  	if (idx >= cc->num_rclks) {
>  		pr_err("%s: invalid index %u\n", __func__, idx);
>  		return ERR_PTR(-EINVAL);

[Severity: Medium]
Does qcom_cc_clk_hw_get() return ERR_PTR(-EINVAL) instead of NULL for a
protected clk_ref when idx >= cc->num_rclks?

qcom_cc_register_clk_refs() skips entries listed in protected-clocks,
leaving cc->clk_refs[idx] NULL so consumers receive a no-op NULL clock.
However, when cc->num_clk_refs > cc->num_rclks and a protected clk_ref
has idx >= cc->num_rclks, lookup falls through to the idx >= cc->num_rclks
check, logs an invalid index error, and fails the consumer's clk_get()
with -EINVAL.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261109-halliday-clk-v1-0-20c3ba8be0bd@gmail.com?part=4