Re: [PATCH 2/4] ASoC: cs35l45: Adds support for ABPE feature

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ASoC: cs35l45: wrong constant NUM_BPE_MODE used for BPE level
  calculation
--

commit 7442e06bcd39f5fc281e35f2b0834bedc508545e
Author: Ricardo Rivera-Matos <rriveram@opensource.cirrus.com>

ASoC: cs35l45: Adds support for ABPE feature

This commit adds boot-time configuration support for the amplifier brownout
prevention engine (ABPE) via device properties.

> diff --git a/sound/soc/codecs/cs35l45.c b/sound/soc/codecs/cs35l45.c
> index 064ee612f05ef..72f4ab1b89bed 100644
> --- a/sound/soc/codecs/cs35l45.c
> +++ b/sound/soc/codecs/cs35l45.c
> @@ -1148,6 +1148,225 @@ static void cs35l45_apply_sync_property_config(struct cs35l45_private *cs35l45)
[ ... ]
> +static int cs35l45_bpe_set_rls_rate(struct cs35l45_private *cs35l45)
> +{
> +	u32 values[CS35L45_BPE_NUM_LEVELS];
> +	u32 packed = 0;
> +	int i, ret;
> +
> +	ret = cs35l45_bpe_read_array(cs35l45, "cirrus,amplifier-bpe-release-rates", values,
> +				     ARRAY_SIZE(values));
> +	if (ret)
> +		return ret;
> +
> +	for (i = 0; i < CS35L45_BPE_NUM_LEVELS; i++) {
> +		if (values[i] > CS35L45_BPE_INST_RLS_RATE_MAX) {
> +			dev_err(cs35l45->dev, "invalid ABPE release rate at level %d\n",
> +				NUM_BPE_MODE - i);
> +			return -EINVAL;
> +		}

[Severity: Low]
Should this use CS35L45_BPE_NUM_LEVELS - 1 - i instead of NUM_BPE_MODE - i?
NUM_BPE_MODE is the sentinel for enum bpe_modes (the number of BPE response
modes) and only happens to equal 3.  The same applies to the error messages
in cs35l45_bpe_set_atk_rate() and cs35l45_bpe_set_thld().

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261109-cs35l45-bpe-v1-0-9d7bc95a90a4@opensource.cirrus.com?part=2