Re: [PATCH 2/3] arm64: dts: rockchip: add the SPI NOR flash supply on Orange Pi 5

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: rockchip: flash@0 node split across dtsi and dts on
  Orange Pi 5
--

commit 2c756f3dcba3203200378627107b75dba49f9ae4
Author: Arun Iyengar <aiyengar1990@gmail.com>

arm64: dts: rockchip: add the SPI NOR flash supply on Orange Pi 5

This commit adds the vcc-supply property pointing to vcc_1v8_s3 for the
SPI NOR flash node on the Orange Pi 5.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts
> index d76bdf1b5e90e..d67c876c80138 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts
> @@ -33,4 +33,8 @@ &pcie2x1l2 {
>  
>  &sfc {
>  	status = "okay";
> +
> +	flash@0 {
> +		vcc-supply = <&vcc_1v8_s3>;
> +	};
>  };

[Severity: Low]
Should vcc-supply be added directly to the existing flash@0 node in
arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtsi instead of splitting
flash@0 across both files?

Both flash@0 and the vcc_1v8_s3 regulator are already defined in
rk3588s-orangepi-5.dtsi under the disabled &sfc node:

arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtsi:&sfc {
	pinctrl-names = "default";
	pinctrl-0 = <&fspim0_pins>;
	status = "disabled";

	flash@0 {
		compatible = "jedec,spi-nor";
		reg = <0x0>;
		spi-max-frequency = <100000000>;
		spi-rx-bus-width = <4>;
		spi-tx-bus-width = <1>;
	};
};

Since &sfc remains disabled on the Orange Pi 5B and 5 Pro, placing
vcc-supply in rk3588s-orangepi-5.dtsi keeps the flash@0 definition in one
place without affecting those boards.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110-opi5-dts-v1-0-582b63d074be@gmail.com?part=2