Re: [PATCH] dt-bindings: iio: adc: lltc,ltc2497: Make vref-supply optional for LTC2305/LTC2309

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] dt-bindings: iio: adc: lltc,ltc2497: vref-supply not required
  for lltc,ltc2493
--

commit 9ef21ec87b9693cbb7eb2ce20677fc640b5dbba6
Author: Kyle Hsieh <kylehsieh1995@gmail.com>

dt-bindings: iio: adc: lltc,ltc2497: Make vref-supply optional for LTC2305/LTC2309

This commit removes vref-supply from the top-level required list in
lltc,ltc2497.yaml and adds a conditional requirement for lltc,ltc2497 and
lltc,ltc2499 so that LTC2305 and LTC2309 nodes can omit it when using
their internal reference.

> diff --git a/Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml b/Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml
> index 4df5aadd1e1d7..22abc6885b5a2 100644
> --- a/Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml
> @@ -47,14 +47,28 @@ properties:
>        - lltc,ltc2499
>  
>    reg: true
> -  vref-supply: true
> +  vref-supply:
> +    description:
> +      Reference voltage supply. The LTC2305 and LTC2309 have an internal
> +      4.096V reference which is used when this property is absent.
>    "#io-channel-cells":
>      const: 1
>  
>  required:
>    - compatible
>    - reg
> -  - vref-supply
> +
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - lltc,ltc2497
> +              - lltc,ltc2499
> +    then:
> +      required:
> +        - vref-supply

[Severity: Medium]
Should lltc,ltc2493 also be included in this enum?

This binding also covers lltc,ltc2493, which like the LTC2497 and LTC2499
has no internal voltage reference and relies on the external vref
regulator in ltc2497core_probe() and ltc2497core_read_raw().  Removing
vref-supply from the top-level required list without adding lltc,ltc2493
to the conditional makes vref-supply optional for LTC2493 nodes.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110-ltc2497-vref-optional-v1-1-35c9657f3c0f@gmail.com?part=1