Re: [PATCH 2/2] dt-bindings: pinctrl: nomadik: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] dt-bindings: pinctrl: nomadik: inverted description for
  ste,sleep-wakeup
- [Low] dt-bindings: pinctrl: nomadik: ste,sleep-gpio is not supported
  by driver
--

commit 42613122aac31a7796978d757c2d840b0d6ab5f2
Author: Linus Walleij <linusw@kernel.org>

dt-bindings: pinctrl: nomadik: Convert to DT schema

This commit converts the ST-Ericsson Nomadik pin controller device tree
binding from plain text to YAML schema.

> diff --git a/Documentation/devicetree/bindings/pinctrl/stericsson,nomadik.yaml b/Documentation/devicetree/bindings/pinctrl/stericsson,nomadik.yaml
> new file mode 100644
> index 0000000000000..48b2b5773946c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/stericsson,nomadik.yaml
> @@ -0,0 +1,113 @@

[ ... ]

> +      ste,sleep-gpio:
> +        description: Sleep GPIO mode enable.
> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        maximum: 1

[Severity: Low]
Should ste,sleep-gpio be dropped or marked deprecated here?  When commit
e32af8894588 ("pinctrl/nomadik: add device tree support") added DT
support, the driver implemented ste,gpio in nmk_cfg_params[] while
ste,nomadik.txt mistakenly documented it as ste,sleep-gpio.  Because
nmk_cfg_params[] does not parse ste,sleep-gpio, any device tree using this
property will have it silently ignored at runtime.

> +      ste,sleep-wakeup:
> +        description: Sleep wakeup disable.
> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        maximum: 1

[Severity: Low]
Should the description for ste,sleep-wakeup say "Sleep wakeup enable."
to match the sibling boolean-like properties?  Both
include/dt-bindings/pinctrl/nomadik.h (SLPM_WAKEUP_DISABLE = 0,
SLPM_WAKEUP_ENABLE = 1) and nmk_pin_sleep_wakeup_modes[] in
drivers/pinctrl/nomadik/pinctrl-nomadik.c treat 0 as disable and 1 as
enable:

drivers/pinctrl/nomadik/pinctrl-nomadik.c:
static const unsigned long nmk_pin_sleep_wakeup_modes[] = {
	PIN_SLPM_WAKEUP_DISABLE,
	PIN_SLPM_WAKEUP_ENABLE,
};

Describing the property as "Sleep wakeup disable." could mislead device
tree authors into inverting the value.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110-ux500-pinctrl-bindings-v1-0-a9f0e9d12d19@kernel.org?part=2