Re: [PATCH 2/3] ARM: dts: ti/omap: describe omap3 i2c via ti-sysc

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] ARM: dts: ti/omap: typo ti-sysc-sidle in omap3.dtsi breaks I2C
  idle modes
--

commit 7b585c63ba05ca384163221aab8d44c23e10bcd7
Author: Andreas Kemnade <andreas@kemnade.info>

ARM: dts: ti/omap: describe omap3 i2c via ti-sysc

This commit converts the OMAP3 I2C controller device tree nodes from the
deprecated ti,hwmods binding to ti-sysc target-module nodes.

> diff --git a/arch/arm/boot/dts/ti/omap/omap3.dtsi b/arch/arm/boot/dts/ti/omap/omap3.dtsi
> index 447736d2e53ca..42d80c7a0a854 100644
> --- a/arch/arm/boot/dts/ti/omap/omap3.dtsi
> +++ b/arch/arm/boot/dts/ti/omap/omap3.dtsi
> @@ -396,31 +396,91 @@ uart3: serial@49020000 {
>  			clock-frequency = <48000000>;
>  		};
>  
> -		i2c1: i2c@48070000 {
> -			compatible = "ti,omap3-i2c";
> -			reg = <0x48070000 0x80>;
> -			interrupts = <56>;
> +		i2c1_target: target-module@48070000 {
> +			compatible = "ti,sysc-omap2", "ti,sysc";
> +			reg = <0x48070000 0x4>,
> +			      <0x48070020 0x4>,
> +			      <0x48070010 0x4>;
> +			reg-names = "rev", "sysc", "syss";
> +			ti,sysc-mask = <(SYSC_OMAP2_CLOCKACTIVITY |
> +					 SYSC_OMAP2_ENAWAKEUP |
> +					 SYSC_OMAP2_SOFTRESET |
> +					 SYSC_OMAP2_AUTOIDLE)>;
> +			ti-sysc-sidle = <SYSC_IDLE_FORCE>,
> +					<SYSC_IDLE_NO>,
> +					<SYSC_IDLE_SMART>;

[Severity: High]
Should ti-sysc-sidle be ti,sysc-sidle here and in i2c2_target and
i2c3_target below?

sysc_init_idlemodes() looks up "ti,sysc-sidle", so this property is
ignored and ddata->cfg.sidlemodes remains 0 for all three I2C target
modules.  As a result, sysc_enable_module() and sysc_disable_module()
skip programming SIDLEMODE and ENAWAKEUP in the I2C_SYSC register,
breaking I2C idle mode and wakeup configuration on OMAP3 (as well as
failing dtbs_check).

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110-i2c-sysc-v1-0-8945eb1d38f0@kemnade.info?part=2