Re: [PATCH v2 2/2] mfd: mxs-lradc: Pass parent IRQs to child drivers

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] mfd: mxs-lradc: Fixes trailer cites driver-core warning commit
--

commit fbb3c430756f909de04d8f2ea7a88e5473612cd3
Author: Fabio Estevam <festevam@gmail.com>

> mfd: mxs-lradc: Pass parent IRQs to child drivers
> 
> The MFD driver stores raw DT interrupt indices in IRQ resources but
> registers its child devices without an IRQ domain or IRQ base. The child
> drivers consequently receive the indices as if they were mapped Linux
> IRQ numbers. IRQ index 0 triggers the platform_get_irq_byname() warning:
> 
>   0 is an invalid IRQ number
> 
> The children then try to recover the indices from their resources and
> map them against the parent OF node. Besides duplicating IRQ names in
> the parent and children, this relies on invalid platform IRQ resources
> and fails when IRQ 0 is rejected.
> 
> Resolve the interrupts with platform_get_irq() in the MFD parent and
> store the mapped IRQs in the shared LRADC data. Drop the child IRQ
> resources and duplicated name arrays, and have both child drivers
> request the mapped IRQs directly. Use the MFD memory base support to
> translate a single relative memory resource shared by both cells.
> 
> Tested on an i.MX28 EVK. The mxs-lradc-ts driver probes successfully,
> touch events are reported, and the touch-detect and LRADC channel 7
> interrupt counters increase as expected.
> 
> Cc: stable@vger.kernel.org
> Suggested-by: Lee Jones <lee@kernel.org>
> Closes: https://lore.kernel.org/linux-input/CAOMZO5CgTzo6GuXptD4mFTN=UsJJqpkixDW1Q64gqZGrij8+uQ@mail.gmail.com/
> Fixes: a85a6c86c25b ("driver core: platform: Clarify that IRQ 0 is invalid")
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

[Severity: Low]
Commit a85a6c86c25b ("driver core: platform: Clarify that IRQ 0 is
invalid") only added a warning in the platform driver core when an
IORESOURCE_IRQ resource has start == 0.  The unmapped DT interrupt indices
in the MFD cell resources and the irq_of_parse_and_map() workaround in the
child drivers were introduced when the driver was split in ead25133e935
("mfd: mxs-lradc: Add support for mxs-lradc"), 6dd112b9f85e ("iio: adc:
mxs-lradc: Add support for ADC driver"), and d81ca730e3e4 ("input:
touchscreen: mxs-lradc: Add support for touchscreen").

Should the Fixes: tag reference those commits instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110141934.42490-1-festevam@gmail.com?part=2