Re: [PATCH 2/2] arm64: dts: rockchip: add USB-C DP altmode support to LubanCat 4

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: rockchip: unsorted &dp0 nodes and properties in
  rk3588s-lubancat-4
--

commit 261397db3cd2b33e2c023e8478bf7780b94572b6
Author: Pufan Jin <cyan2254650260@gmail.com>

arm64: dts: rockchip: add USB-C DP altmode support to LubanCat 4

This commit adds DisplayPort alternate mode support on the USB-C connector
of the EmbedFire LubanCat 4 by wiring the USB-C connector, usbdp_phy0, dp0,
and VOP2 VP1 in the device tree.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-lubancat-4.dts b/arch/arm64/boot/dts/rockchip/rk3588s-lubancat-4.dts
> index a94aaddb2749e..6c5a942dfd854 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588s-lubancat-4.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-lubancat-4.dts

[ ... ]

> @@ -857,6 +872,9 @@ &usb_host2_xhci {
>  
>  &usbdp_phy0 {
>  	orientation-switch;
> +	mode-switch;
> +	sbu1-dc-gpios = <&gpio4 RK_PB3 GPIO_ACTIVE_HIGH>;
> +	sbu2-dc-gpios = <&gpio4 RK_PB4 GPIO_ACTIVE_HIGH>;
>  	status = "okay";

[ ... ]

> @@ -895,3 +929,26 @@ vp0_out_hdmi0: endpoint@ROCKCHIP_VOP2_EP_HDMI0 {
>  		remote-endpoint = <&hdmi0_in_vp0>;
>  	};
>  };
> +
> +&dp0 {
> +	status = "okay";
> +};
> +
> +&dp0_in {
> +	dp0_in_vp1: endpoint {
> +		remote-endpoint = <&vp1_out_dp0>;
> +	};
> +};
> +
> +&dp0_out {
> +	dp0_out_con: endpoint {
> +		remote-endpoint = <&usbdp_phy0_dp_in>;
> +	};
> +};

[Severity: Low]
This isn't a bug, but per the devicetree coding style and the rest of this
file, label reference nodes are sorted alphabetically, so &dp0, &dp0_in, and
&dp0_out should be placed between &cpu_l3 and &gmac1 rather than between &vp0
and &vp1.  Similarly, in &usbdp_phy0, mode-switch should be placed before
orientation-switch.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110193028.512456-1-cyan2254650260@gmail.com?part=2