Re: [PATCH v3 2/2] arm64: dts: qcom: nord: add CoreSight debug nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] arm64: dts: qcom: nord: unresolved aoss_qmp phandle in
  CoreSight nodes
- [High] arm64: dts: qcom: nord: missing arm,primecell compatible on
  tn@115bc000
--

commit 6b7289c2147fc057245f0e8ab533b94124ab13d2
Author: Jie Gan <jie.gan@oss.qualcomm.com>

arm64: dts: qcom: nord: add CoreSight debug nodes

This commit adds the CoreSight trace topology nodes for the Qualcomm Nord
SoC to nord.dtsi.

> diff --git a/arch/arm64/boot/dts/qcom/nord.dtsi b/arch/arm64/boot/dts/qcom/nord.dtsi
> index fdbe290350ddd..b03a33d99a1b7 100644
> --- a/arch/arm64/boot/dts/qcom/nord.dtsi
> +++ b/arch/arm64/boot/dts/qcom/nord.dtsi

[ ... ]

> @@ -1654,239 +1680,3181 @@ tlmm: pinctrl@f100000 {
>  			wakeup-parent = <&pdc>;
>  		};
>  

[ ... ]

> +		ctcu@10001000 {
> +			compatible = "qcom,nord-ctcu", "qcom,sa8775p-ctcu";
> +			reg = <0x0 0x10001000 0x0 0x1000>;
> +
> +			clocks = <&aoss_qmp>;
> +			clock-names = "apb";

[Severity: High]
Where is the aoss_qmp label defined?  All 105 clocked CoreSight nodes added
in this patch reference <&aoss_qmp>, which does not exist in nord.dtsi or
any of the Nord board DTS files, causing dtc to fail with a
phandle_references error when building nord-ride.dtb and nord-rrd.dtb.

[ ... ]

> +		tn@115bc000 {
> +			compatible = "qcom,coresight-tnoc";
> +			reg = <0x0 0x115bc000 0x0 0x3c00>;
> +
> +			clocks = <&aoss_qmp>;
> +			clock-names = "apb_pclk";

[Severity: High]
Should tn@115bc000 include "arm,primecell" in its compatible list, as
required by Documentation/devicetree/bindings/arm/qcom,coresight-tnoc.yaml?

Without "arm,primecell", of_platform_bus_create() registers tn@115bc000 as a
platform_device rather than an amba_device, so trace_noc_driver (an
amba_driver in drivers/hwtracing/coresight/coresight-tnoc.c) never binds to
it and none of the 33 trace inputs routed through tn_ag can form a trace
path to the sinks.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111041956.3639092-1-shengchao.guo@oss.qualcomm.com?part=2