From: sashiko-bot@kernel.org
To: "Frank Obergfell" <frank.obergfell@bytesatwork.ch>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, robh@kernel.org, conor+dt@kernel.org,
Frank.Li@kernel.org
Subject: Re: [PATCH v2 5/5] arm64: dts: freescale: Add support for bytesatwork i.MX93
Date: Wed, 11 Nov 2026 08:36:02 +0000 [thread overview]
Message-ID: <sashiko-outbox-208621@kernel.org> (raw)
In-Reply-To: <20261111081150.950272-6-frank.obergfell@bytesatwork.ch>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: freescale: imx93-bytedevkit: unused backlight-lvds
left enabled
--
commit c60831b496cfd3af119e905c5fcb49dc6905f857
Author: Frank Obergfell <frank.obergfell@bytesatwork.ch>
arm64: dts: freescale: Add support for bytesatwork i.MX93
This commit adds device tree files for the bytesatwork i.MX93 byteENGINE
OSM module and the byteDEVKIT board.
> diff --git a/arch/arm64/boot/dts/freescale/imx93-bytedevkit.dts b/arch/arm64/boot/dts/freescale/imx93-bytedevkit.dts
> new file mode 100644
> index 0000000000000..cb5d17c8444c3
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx93-bytedevkit.dts
[ ... ]
> + lcd_bl: backlight-lvds {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_lvds_backlight>;
> + compatible = "gpio-backlight";
> + gpios = <&gpio2 26 GPIO_ACTIVE_HIGH>;
> + default-on;
> + };
[Severity: Low]
Should backlight-lvds be disabled or removed while the LVDS display
pipeline and touch controller on lpi2c1 are disabled? With default-on set
and no panel referencing &lcd_bl, gpio_backlight_probe() registers an
unused backlight device and drives GPIO2_IO26 high at boot even though
only the MIPI DSI panel is active.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261111081150.950272-1-frank.obergfell@bytesatwork.ch?part=5
next prev parent reply other threads:[~2026-11-11 8:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 8:11 [PATCH v2 0/5] arm64: dts: freescale: Add support for bytesatwork byteDEVKIT i.MX93 Frank Obergfell
2026-11-11 8:11 ` [PATCH v2 1/5] dt-bindings: display: panel: ilitek,ili9806e: Add Youritech et050fw01-kt Frank Obergfell
2026-11-11 8:45 ` Daniel Baluta
2026-11-11 8:11 ` [PATCH v2 2/5] drm/panel: ilitek-ili9806e: Add support for Youritech et050fw01-kt panel Frank Obergfell
2026-11-11 8:11 ` [PATCH v2 3/5] arm64: dts: freescale: imx93: Add MIPI DSI controller node Frank Obergfell
2026-11-11 8:11 ` [PATCH v2 4/5] dt-bindings: arm: fsl: Add byteENGINE i.MX93 platforms Frank Obergfell
2026-11-11 8:46 ` Daniel Baluta
2026-11-11 8:11 ` [PATCH v2 5/5] arm64: dts: freescale: Add support for bytesatwork i.MX93 Frank Obergfell
2026-11-11 8:36 ` sashiko-bot [this message]
2026-11-11 8:43 ` Daniel Baluta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-208621@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=frank.obergfell@bytesatwork.ch \
--cc=imx@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox