Re: [PATCH v2 2/8] spi: cadence-xspi: wait for the controller initialization on resume

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] spi: cadence-xspi: missing Fixes trailer for cdns_xspi_resume()
  init wait fix
--

commit 1cfb3d5d49d047b5fae8e262c396fe9156989594
Author: Nuno Sá <nuno.sa@analog.com>

> spi: cadence-xspi: wait for the controller initialization on resume
>
> The controller IP might lose power across a system suspend (e.g. its
> power domain being gated). In that case, it goes through its reset and
> initialization process again on resume, which is only done when the
> INIT_COMPLETED bit is set in the controller status register. However,
> the resume path reconfigures the controller right away.
>
> Add a helper to wait for the controller to complete its initialization
> and use it on resume before configuring anything. If the controller did
> not lose power, the bit is already set and there is nothing to wait for.
>
> The helper will also be used after the optional hardware reset, added
> in a following patch.
>
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>

[Severity: Low]
This fixes a bug in cdns_xspi_resume().  Should this include:

  Fixes: db6a59cfcc93 ("spi: cadence-xspi: support suspend/resume")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111-xspi-cadence-add-acmd-v2-0-d339046ada8b@analog.com?part=2