Re: [PATCH v3 3/4] hwmon: Add Microchip LAN969x fan controller driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] hwmon: lan969x-fan: separate __free() declaration in
  lan969x_fan_probe()
--

commit b2df768159182a27301144a0ba71d10e45a494fd
Author: Robert Marko <robert.marko@sartura.hr>

hwmon: Add Microchip LAN969x fan controller driver

This commit adds a hwmon driver for the Microchip LAN969x fan controller,
supporting tachometer input, PWM output, and thermal cooling.

> diff --git a/drivers/hwmon/lan969x-fan.c b/drivers/hwmon/lan969x-fan.c
> new file mode 100644
> index 0000000000000..fae0248658818
> --- /dev/null
> +++ b/drivers/hwmon/lan969x-fan.c
[ ... ]
> +static int lan969x_fan_probe(struct platform_device *pdev)
> +{
> +	struct thermal_cooling_device *cdev;
> +	struct device *dev = &pdev->dev;
> +	struct lan969x_fan *fan;
> +	struct device_node *fan_np __free(device_node) = NULL;
> +	u32 initial_pwm;
> +	int ret;
> +
> +	fan = devm_kzalloc(dev, sizeof(*fan), GFP_KERNEL);
> +	if (!fan)
> +		return -ENOMEM;
> +
> +	fan->base = devm_platform_ioremap_resource(pdev, 0);
> +	if (IS_ERR(fan->base))
> +		return PTR_ERR(fan->base);
> +
> +	fan->pulses_per_revolution = 2;
> +	fan_np = of_get_available_child_by_name(dev->of_node, "fan");

[Severity: Low]
This isn't a bug, but per the cleanup.h conventions, fan_np should be
defined and initialized in a single statement at the point of assignment
rather than declared initialized to NULL at the top of
lan969x_fan_probe().

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111161619.232141-1-robert.marko@sartura.hr?part=3