Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Pufan Jin" <cyan2254650260@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 2/2] ARM: dts: zynq: Add ALINX AX7Z020B development board
Date: Wed, 11 Nov 2026 17:10:24 +0000	[thread overview]
Message-ID: <sashiko-outbox-209381@kernel.org> (raw)
In-Reply-To: <20261111162917.97532-3-cyan2254650260@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ARM: dts: zynq: unaddressed mdio child in gem0 triggers dtc W=1
  warning
--

commit 3898a396db65d191993e3c2e496f86fb25c55e4f
Author: Pufan Jin <cyan2254650260@gmail.com>

ARM: dts: zynq: Add ALINX AX7Z020B development board

This commit adds devicetree support for the ALINX AC7Z020 system on module
and the ALINX AX7Z020B development board.

Link: https://www.alinx.com/

> diff --git a/arch/arm/boot/dts/xilinx/zynq-alinx-ax7z020b.dts b/arch/arm/boot/dts/xilinx/zynq-alinx-ax7z020b.dts
> new file mode 100644
> index 0000000000000..472d9fcaafa69
> --- /dev/null
> +++ b/arch/arm/boot/dts/xilinx/zynq-alinx-ax7z020b.dts

[ ... ]

> +&gem0 {
> +	status = "okay";
> +	phy-mode = "rgmii-id";
> +	phy-handle = <&ethernet_phy>;
> +
> +	mdio {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		ethernet_phy: ethernet-phy@1 {
> +			reg = <1>;

[Severity: Low]
Does wrapping ethernet-phy@1 in an unaddressed mdio node trigger a dtc
avoid_unnecessary_addr_size warning when building with W=1?

gem0 in zynq-7000.dtsi defines #address-cells and #size-cells, so dtc warns
when its only direct child has no reg or ranges property.  Placing
ethernet-phy@1 directly under &gem0, as other Zynq-7000 boards do, or
deleting #address-cells and #size-cells on &gem0 avoids the warning.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111162917.97532-1-cyan2254650260@gmail.com?part=2

  reply	other threads:[~2026-11-11 17:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11 16:29 [PATCH v2 0/2] ARM: dts: zynq: Add ALINX AX7Z020B development board Pufan Jin
2026-11-11 16:29 ` [PATCH v2 1/2] dt-bindings: soc: xilinx: Add ALINX AX7Z020B board Pufan Jin
2026-11-11 16:29 ` [PATCH v2 2/2] ARM: dts: zynq: Add ALINX AX7Z020B development board Pufan Jin
2026-11-11 17:10   ` sashiko-bot [this message]
2026-11-11 17:29   ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-209381@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=cyan2254650260@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox