Re: [PATCH v4 3/7] regulator: pm8008: Add mode voting support for PM8010

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] regulator: pm8008: wrong hpm_min_load_uA for PM8010 L1/L2 in
  pm8010_reg_data
--

commit e894320c5a690e879a2556e289265d1ae5f7176f
Author: Dhruvin Rajpura <drajpura@qti.qualcomm.com>

regulator: pm8008: Add mode voting support for PM8010

This commit adds set_mode, get_mode, and get_optimum_mode support for
PM8010 LDO1 and LDO2 in the pm8008 regulator driver.

> diff --git a/drivers/regulator/qcom-pm8008-regulator.c b/drivers/regulator/qcom-pm8008-regulator.c
> index 0ea4ac016dc22..395d5582f6af0 100644
> --- a/drivers/regulator/qcom-pm8008-regulator.c
> +++ b/drivers/regulator/qcom-pm8008-regulator.c

[ ... ]

> @@ -84,9 +97,10 @@ static const struct pm8008_regulator_data pm8008_reg_data[] = {
>  	PM8008_REGULATOR("ldo7", "vdd-l7",    0x4600, 200000, pm8008_pldo_ranges),
>  };
>  
> +/* LPM setting is supported for only N-type LDOs of PM8010 (L1 and L2) */
>  static const struct pm8008_regulator_data pm8010_reg_data[] = {
> -	PM8008_REGULATOR("ldo1", "vdd-l1-l2", 0x4000, 172000, pm8010_nldo_ranges),
> -	PM8008_REGULATOR("ldo2", "vdd-l1-l2", 0x4100, 172000, pm8010_nldo_ranges),
> +	PM8010_REGULATOR("ldo1", "vdd-l1-l2", 0x4000, 172000, pm8010_nldo_ranges, 100000),
> +	PM8010_REGULATOR("ldo2", "vdd-l1-l2", 0x4100, 172000, pm8010_nldo_ranges, 100000),

[Severity: Medium]
Should hpm_min_load_uA for ldo1 and ldo2 in pm8010_reg_data be 30000
instead of 100000?

In drivers/regulator/qcom-rpmh-regulator.c, pm8010_vreg_data defines the
same PM8010 LDO1 and LDO2 regulators using pmic5_nldo502, which sets
hpm_min_load_uA to 30000 (30 mA):

drivers/regulator/qcom-rpmh-regulator.c:pmic5_nldo502 {
    ...
	.hpm_min_load_uA = 30000,
	.pmic_mode_map = pmic_mode_map_pmic5_ldo,
    ...
}

With hpm_min_load_uA set to 100000, pm8010_regulator_get_optimum_mode()
keeps LDO1 and LDO2 in REGULATOR_MODE_IDLE (LDO_MODE_LPM) when consumers
request loads between 30000 uA and 99999 uA via regulator_set_load(),
which can cause output droop or brownout under moderate loads.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111-pm8010_i2c_support-v4-0-4549cab1c8e4@oss.qualcomm.com?part=3