Re: [PATCH v2 1/3] arm64: dts: qcom: msm8916: Disable disconnected DSI

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: qcom: msm8916: mdss_dsi0 left disabled on apq8016
  boards
--

commit 1c53100e6d0a805c4396ae622f04768b412718b0
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

arm64: dts: qcom: msm8916: Disable disconnected DSI

This commit disables mdss_dsi0 and mdss_dsi0_phy by default in msm8916.dtsi
and enables them in board DTS files that have a panel or bridge attached.

> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> index ba6ccf0db16ab..6c94489f5f707 100644
> --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> @@ -262,6 +262,10 @@ &mdss_dsi0_out {
>  	remote-endpoint = <&adv7533_in>;
>  };
>  
> +&mdss_dsi0_phy {
> +	status = "okay";
> +};
> +
>  &mpss {
>  	status = "okay";
>  
> diff --git a/arch/arm64/boot/dts/qcom/apq8016-schneider-hmibsc.dts b/arch/arm64/boot/dts/qcom/apq8016-schneider-hmibsc.dts
> index ce75046ffdac4..370ad8b01a1a0 100644
> --- a/arch/arm64/boot/dts/qcom/apq8016-schneider-hmibsc.dts
> +++ b/arch/arm64/boot/dts/qcom/apq8016-schneider-hmibsc.dts
> @@ -218,6 +218,10 @@ &mdss_dsi0_out {
>  	remote-endpoint = <&adv7533_in>;
>  };
>  
> +&mdss_dsi0_phy {
> +	status = "okay";
> +};
> +
>  &pm8916_codec {
>  	qcom,mbhc-vthreshold-low = <75 150 237 450 500>;
>  	qcom,mbhc-vthreshold-high = <75 150 237 450 500>;

[Severity: High]
Should apq8016-sbc.dts and apq8016-schneider-hmibsc.dts also enable
&mdss_dsi0?

Both boards connect DSI0 to the ADV7533 bridge via &mdss_dsi0_out and do
not have an existing &mdss_dsi0 block.  With mdss_dsi0 disabled in
msm8916.dtsi, the DSI controller and ADV7533 bridge fail to probe on both
boards.  Furthermore, because apq8016-schneider-hmibsc.dts leaves &gpu
disabled, msm_drv_probe() finds zero sub-components and passes a NULL
match pointer to component_master_add_with_match(), causing a NULL pointer
dereference at boot.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111-display-msm-of-graph-v2-0-fdf8fd97f49d@oss.qualcomm.com?part=1