Re: [PATCH 3/5] arm64: dts: mediatek: mt8173: Add the keypad controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: mediatek: undocumented mediatek,mt8173-keypad
  compatible
--

commit 4cfa9faa42ef443ea3e9f6ceaef3c60ddc279da5
Author: Ryan Brue <ryanbrue.dev@gmail.com>

arm64: dts: mediatek: mt8173: Add the keypad controller

This commit adds the keypad controller device tree node to mt8173.dtsi
with a disabled status for boards to enable.

> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> index 2ecdea33672ea..61261fe643ab7 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> @@ -555,6 +555,16 @@ pwrap: pwrap@1000d000 {
>  			clock-names = "spi", "wrap";
>  		};
>  
> +		keyboard: keyboard@10010000 {
> +			compatible = "mediatek,mt8173-keypad",
> +				     "mediatek,mt6779-keypad";

[Severity: Low]
Should "mediatek,mt8173-keypad" be documented in
Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml first?
Without adding it to the compatible enum in the binding schema, this causes
checkpatch.pl warnings and dtbs_check validation failures on MT8173 device
trees.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111-rbrue-suez-upstreaming-amazon-suez-dts-v1-0-77b47cdea702@gmail.com?part=3