Re: [PATCH v4 2/2] arm64: dts: qcom: ipq5332: add support to get watchdog bootstatus from IMEM

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] arm64: dts: qcom: ipq5332: sram@8600000 size 0x14000
  mismatches IMEM bounds
--

commit 2ebab85765d6af41cdb12da7f09a167a744fb0e3
Author: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>

arm64: dts: qcom: ipq5332: add support to get watchdog bootstatus from IMEM

This commit adds the IMEM SRAM node with a restart_reason subnode and
references it from the watchdog node on IPQ5332.

> diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> index 25c32e966de92..06e08238a12c0 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> @@ -493,6 +493,21 @@ qpic_nand: spi@79b0000 {
>  			status = "disabled";
>  		};
>  
> +		sram@8600000 {
> +			compatible = "qcom,ipq5332-imem", "mmio-sram";
> +			reg = <0x08600000 0x14000>;
> +			ranges = <0 0x08600000 0x14000>;

[Severity: Medium]
Should the reg and ranges size of sram@8600000 be 0x1000 instead of
0x14000, or is the commit message inaccurate?

The commit message states that the overall IMEM region is 32KB (0x8000) and
only the initial 4KB (0x1000) is accessible by all masters in the SoC, yet
reg and ranges specify 0x14000 (80KB). Because mmio-sram maps the full reg
range in sram_probe() and registers all unreserved subranges into
sram->pool via sram_reserve_regions() -> gen_pool_add_virt(), exposing
offsets beyond the 4KB accessible window in the pool can cause bus aborts
or access violations if an in-kernel consumer allocates from it. The commit
message also states that this patch parses the information in the watchdog
driver, whereas the diff only updates the devicetree.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112-imem_restart_reason-v4-0-3c7177529526@oss.qualcomm.com?part=2