Re: [PATCH v2 5/6] drm/msm/dpu: Add SM7250 support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] drm/msm/dpu: missing qcom,sm7250 in qcom_ubwc_configs breaks
  probe
--

commit 028e2a72798ab5d56d8d81bb276fb38107826ea0
Author: Ishu Brar <patches@brar.si>

drm/msm/dpu: Add SM7250 support

This commit adds DPU 6.1 hardware catalog definitions and device tree match
data for the Qualcomm SM7250 platform.

> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> index 1b6286dccfc00..908d401ec4020 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> @@ -1506,6 +1506,7 @@ static const struct of_device_id dpu_dt_match[] = {
>  	{ .compatible = "qcom,sm6350-dpu", .data = &dpu_sm6350_cfg, },
>  	{ .compatible = "qcom,sm6375-dpu", .data = &dpu_sm6375_cfg, },
>  	{ .compatible = "qcom,sm7150-dpu", .data = &dpu_sm7150_cfg, },
> +	{ .compatible = "qcom,sm7250-dpu", .data = &dpu_sm7250_cfg, },

[Severity: High]
Does qcom_ubwc_configs in drivers/soc/qcom/ubwc_config.c also need an entry
for "qcom,sm7250"?

During probe, msm_mdss_init() and dpu_kms_hw_init() call
qcom_ubwc_config_get_data(), which looks up the machine root compatible in
qcom_ubwc_configs via of_machine_get_match_data().  Without a matching
"qcom,sm7250" entry in qcom_ubwc_configs, qcom_ubwc_config_get_data()
returns ERR_PTR(-EINVAL) and display initialization on SM7250 fails.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112-dpu-sm7250-v2-0-8e925a3a8a7d@brar.si?part=5