Re: [PATCH v16 3/9] clk: realtek: Add support for phase locked loops (PLLs)

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] clk: realtek: missing linux/limits.h include in freq_table.c
  breaks build
--

commit 05422d9707f4d9d5ef01c91a7d3ca363d63c729c
Author: Cheng-Yu Lee <cylee12@realtek.com>

clk: realtek: Add support for phase locked loops (PLLs)

This commit adds regmap-based PLL clock operations and frequency table
lookup helpers for Realtek SoCs.

> diff --git a/drivers/clk/realtek/freq_table.c b/drivers/clk/realtek/freq_table.c
> new file mode 100644
> index 0000000000000..0f977a3fc9021
> --- /dev/null
> +++ b/drivers/clk/realtek/freq_table.c
> @@ -0,0 +1,62 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +
> +#include <linux/types.h>
> +#include "freq_table.h"
> +
> +#define IS_FREQ_TABLE_END(_f) ((_f)->rate == 0)
> +
> +const struct rtk_freq_table *ftbl_find_closest_by_rate(const struct rtk_freq_table *ftbl,
> +						       unsigned long rate,
> +						       unsigned long min_rate,
> +						       unsigned long max_rate)
> +{
> +	const struct rtk_freq_table *best = NULL;
> +	unsigned long best_delta = ULONG_MAX;

[Severity: High]
Does freq_table.c need to include <linux/limits.h> for ULONG_MAX?

Neither <linux/types.h> nor freq_table.h pulls in <linux/limits.h>, so
building with CONFIG_RTK_CLK_COMMON enabled fails at this commit with an
undeclared identifier error for ULONG_MAX.  The include is added later in
the series by commit "clk: realtek: Add support for MMC-tuned PLL clocks",
leaving the intermediate commits unbuildable during bisection.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112052544.555563-1-eleanor.lin@realtek.com?part=3