Re: [PATCH] arm64: dts: qcom: eliza-mtp: Add WCD9390 USB-SS mux for DP alt mode

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: qcom: eliza-mtp: &i2c3 node placed out of
  alphabetical order
--

commit dceba04a5137daf6908c61ec04a54977dab1b62a
Author: Balaji Kalkonda <balaji.kalkonda@oss.qualcomm.com>

arm64: dts: qcom: eliza-mtp: Add WCD9390 USB-SS mux for DP alt mode

This commit adds the WCD9390 USB-SS typec-mux node on i2c3 and wires its
SBU endpoint to the pmic-glink USB-C connector on eliza-mtp.

> diff --git a/arch/arm64/boot/dts/qcom/eliza-mtp.dts b/arch/arm64/boot/dts/qcom/eliza-mtp.dts
> index ee05192adcfb9..d848ae77ab851 100644
> --- a/arch/arm64/boot/dts/qcom/eliza-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/eliza-mtp.dts
[ ... ]
> @@ -112,6 +120,34 @@ vph_pwr: regulator-vph-pwr {
>  	};
>  };
>  
> +&i2c3 {
> +	status = "okay";
> +
> +	wcd_usbss: typec-mux@e {
> +		compatible = "qcom,wcd9390-usbss";
> +		reg = <0xe>;
> +
> +		vdd-supply = <&vreg_l7b>;
> +		reset-gpios = <&tlmm 152 GPIO_ACTIVE_HIGH>;
> +
> +		mode-switch;
> +		orientation-switch;
> +
> +		ports {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			port@0 {
> +				reg = <0>;
> +
> +				wcd_usbss_sbu_mux: endpoint {
> +					remote-endpoint = <&pmic_glink_sbu>;
> +				};
> +			};
> +		};
> +	};
> +};
> +
>  &apps_rsc {
>  	regulators-0 {
>  		compatible = "qcom,pm7550-rpmh-regulators";

[Severity: Low]
Should &i2c3 be placed between &gpu_zap_shader and &mdss to keep the
phandle-referenced nodes in alphabetical order?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112-eliza-wcd-mux-fix-v1-1-70c521781ac1@oss.qualcomm.com?part=1