Re: [PATCH v4 3/3] arm64: dts: qcom: shikra: enable WCN SW_CTRL wakeup

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: qcom: shikra: unconfigured trigger type on
  wcn3988-pmu wake IRQ
--

commit a2fb22de0f4bb902b0590abe34c32d49b1aa90fd
Author: Linghui Wu <linghui.wu@oss.qualcomm.com>

arm64: dts: qcom: shikra: enable WCN SW_CTRL wakeup

This commit adds the wakeup-source property to the wcn3988-pmu nodes on
the Shikra CQM and IQS SoMs so the WCN power sequencer uses the SW_CTRL
GPIO as a wake IRQ.

> diff --git a/arch/arm64/boot/dts/qcom/shikra-cqm-som.dtsi b/arch/arm64/boot/dts/qcom/shikra-cqm-som.dtsi
> index 95eb7255fb227..c7b894b6126c1 100644
> --- a/arch/arm64/boot/dts/qcom/shikra-cqm-som.dtsi
> +++ b/arch/arm64/boot/dts/qcom/shikra-cqm-som.dtsi
> @@ -102,6 +102,7 @@ wcn3988-pmu {
>  		pinctrl-names = "default";
>  
>  		swctrl-gpios = <&tlmm 88 GPIO_ACTIVE_HIGH>;
> +		wakeup-source;
>  
>  		vddio-supply = <&pm4125_l7>;
>  		vddxo-supply = <&pm4125_l13>;
> diff --git a/arch/arm64/boot/dts/qcom/shikra-iqs-som.dtsi b/arch/arm64/boot/dts/qcom/shikra-iqs-som.dtsi
> index 99e974f6ca7e1..321bc64237280 100644
> --- a/arch/arm64/boot/dts/qcom/shikra-iqs-som.dtsi
> +++ b/arch/arm64/boot/dts/qcom/shikra-iqs-som.dtsi
> @@ -85,6 +85,7 @@ wcn3988-pmu {
>  		pinctrl-names = "default";
>  
>  		swctrl-gpios = <&tlmm 88 GPIO_ACTIVE_HIGH>;
> +		wakeup-source;
>  
>  		vddio-supply = <&pm8150_s4>;
>  		vddxo-supply = <&pm8150_l12>;

[Severity: High]
Does enabling wakeup-source here leave the SW_CTRL wake IRQ without a
configured trigger type?

In pwrseq_qcom_wcn_probe(), the driver maps swctrl_gpio via gpiod_to_irq()
and passes it to dev_pm_set_dedicated_wake_irq():

drivers/power/sequencing/pwrseq-qcom-wcn.c:pwrseq_qcom_wcn_probe() {
	...
		wake_irq = gpiod_to_irq(swctrl_gpio);
		if (wake_irq < 0)
			return dev_err_probe(dev, wake_irq,
					     "Failed to get the SW_CTRL wake IRQ\n");

		ret = devm_device_init_wakeup(dev);
		if (ret)
			return dev_err_probe(dev, ret,
					     "Failed to enable wakeup\n");

		ret = dev_pm_set_dedicated_wake_irq(dev, wake_irq);
	...
}

gpiochip_to_irq() creates the hierarchical TLMM/MPM mapping with
IRQ_TYPE_NONE, where msm_gpio_init() initializes the flow handler to
handle_bad_irq, and __dev_pm_set_dedicated_wake_irq() requests the
threaded IRQ without any IRQF_TRIGGER_* flags. Because both the requested
flags and existing trigger type are IRQ_TYPE_NONE, __setup_irq() skips
__irq_set_trigger().

Neither msm_gpio_irq_set_type() nor qcom_mpm_set_type() runs for GPIO 88,
leaving TLMM and vMPM trigger registers unprogrammed and the flow handler
set to handle_bad_irq when the wake IRQ is armed on suspend.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112072009.3815276-1-linghui.wu@oss.qualcomm.com?part=3