Re: [PATCH v2 2/2] ARM: l2c: honour status = "disabled" on the L2 cache node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] ARM: l2c: device_node refcount leak on disabled DT node in
  l2x0_of_init()
--

commit 98b76cb0386da8baf1e847208a1b97f4eab12a69
Author: Agustin Santiago Isasmendi <isasmendi.agus@gmail.com>

ARM: l2c: honour status = "disabled" on the L2 cache node

This commit checks of_device_is_available() in l2x0_of_init() so that an
L2 cache controller node marked disabled in the device tree is skipped.

> diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c
> index 470867160076f..5d6a4c040a506 100644
> --- a/arch/arm/mm/cache-l2x0.c
> +++ b/arch/arm/mm/cache-l2x0.c
> @@ -1772,6 +1772,11 @@ int __init l2x0_of_init(u32 aux_val, u32 aux_mask)
>  	if (!np)
>  		return -ENODEV;
>  
> +	if (!of_device_is_available(np)) {
> +		pr_info("L2C: disabled by the device tree\n");
> +		return -ENODEV;
> +	}

[Severity: Medium]
Does this leak a reference to np?  of_find_matching_node() returns np with
its refcount incremented, and unlike the drivers/cache/ drivers mentioned
in the commit message (which declare np with __free(device_node)),
l2x0_of_init() uses a plain struct device_node *np and returns here
without calling of_node_put(np).

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112072953.989664-1-isasmendi.agus@gmail.com?part=2